Skip to content

Commit b6d02cd

Browse files
authored
fix(common): cell range decorator should be hidden after onDragEnd (#924)
- issue was found when user has an Editor open and then click on a row checkbox and start dragging that row checkbox cell, then the cell range decorator appears but never goes away because checkbox plugin has prevents event bubbling when having an editor and in turns wasn't destroying the cell range decorator when it should, the cell range decorator isn't visible but it has a z-index of 9999 and even though it's invisible it was showing on top of everything else making the cell behind it unclickable for the size of the cell range decorator (usually about the size of 2-3 cells)
1 parent 012b74c commit b6d02cd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/plugins/slick.cellrangeselector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,7 @@ export class SlickCellRangeSelector implements SlickPlugin {
365365
}
366366

367367
protected handleDragEnd(e: Event, dd: DragPosition) {
368+
this._decorator.hide();
368369
if (!this._dragging) {
369370
return;
370371
}
@@ -373,7 +374,6 @@ export class SlickCellRangeSelector implements SlickPlugin {
373374
e.stopImmediatePropagation();
374375

375376
this.stopIntervalTimer();
376-
this._decorator.hide();
377377
this.onCellRangeSelected.notify({
378378
range: new SlickRange(
379379
dd.range.start.row ?? 0,

0 commit comments

Comments
 (0)