Skip to content

Commit 36173fc

Browse files
committed
chore: add more TS types to DataView
1 parent cd29a24 commit 36173fc

File tree

3 files changed

+20
-14
lines changed

3 files changed

+20
-14
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export interface DataViewHints {
2+
ignoreDiffsBefore?: number;
3+
ignoreDiffsAfter?: number;
4+
isFilterNarrowing?: boolean;
5+
isFilterExpanding?: boolean;
6+
isFilterUnchanged?: boolean;
7+
}

src/models/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export * from './core.interface';
1515
export * from './cssDeclaration.interface';
1616
export * from './customTooltipOption.interface';
1717
export * from './dataViewEvents.interface';
18+
export * from './dataViewHints.interface';
1819
export * from './domEvent.interface';
1920
export * from './drag.interface';
2021
export * from './draggableGroupingOption.interface';

src/slick.dataview.ts

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import type {
22
Aggregator,
33
CssStyleHash,
44
CustomDataView,
5+
DataViewHints,
56
Grouping,
67
GroupingFormatterItem,
78
ItemMetadata,
@@ -77,8 +78,8 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
7778
protected sortAsc: boolean | undefined = true;
7879
protected fastSortField?: string | null | (() => string);
7980
protected sortComparer!: ((a: TData, b: TData) => number);
80-
protected refreshHints: any = {};
81-
protected prevRefreshHints: any = {};
81+
protected refreshHints: DataViewHints = {};
82+
protected prevRefreshHints: DataViewHints = {};
8283
protected filterArgs: any;
8384
protected filteredItems: TData[] = [];
8485
protected compiledFilter?: FilterFn<TData> | null;
@@ -187,7 +188,7 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
187188
}
188189
}
189190

190-
setRefreshHints(hints: any) {
191+
setRefreshHints(hints: DataViewHints) {
191192
this.refreshHints = hints;
192193
}
193194

@@ -832,8 +833,8 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
832833
collapseGroup(...args: any) {
833834
const calledArgs = Array.prototype.slice.call(args);
834835
const arg0 = calledArgs[0];
835-
let groupingKey;
836-
let level;
836+
let groupingKey: string;
837+
let level: number;
837838

838839
if (args.length === 1 && arg0.indexOf(this.groupingDelimiter) !== -1) {
839840
groupingKey = arg0;
@@ -856,8 +857,8 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
856857
expandGroup(...args: any) {
857858
const calledArgs = Array.prototype.slice.call(args);
858859
const arg0 = calledArgs[0];
859-
let groupingKey;
860-
let level;
860+
let groupingKey: string;
861+
let level: number;
861862

862863
if (args.length === 1 && arg0.indexOf(this.groupingDelimiter) !== -1) {
863864
level = arg0.split(this.groupingDelimiter).length - 1;
@@ -876,8 +877,8 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
876877
}
877878

878879
protected extractGroups(rows: any[], parentGroup?: SlickGroup_) {
879-
let group;
880-
let val;
880+
let group: SlickGroup_;
881+
let val: any;
881882
const groups: SlickGroup_[] = [];
882883
const groupsByVal: any = {};
883884
let r;
@@ -1182,10 +1183,7 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
11821183
*/
11831184
protected setFunctionName(fn: any, fnName: string) {
11841185
try {
1185-
Object.defineProperty(fn, 'name', {
1186-
writable: true,
1187-
value: fnName
1188-
});
1186+
Object.defineProperty(fn, 'name', { writable: true, value: fnName });
11891187
} catch (err) {
11901188
fn.name = fnName;
11911189
}
@@ -1265,7 +1263,7 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
12651263
}
12661264

12671265
protected getRowDiffs(rows: TData[], newRows: TData[]) {
1268-
let item: any;
1266+
let item: TData | SlickNonDataItem | SlickDataItem | SlickGroup_;
12691267
let r;
12701268
let eitherIsNonData;
12711269
const diff: number[] = [];

0 commit comments

Comments
 (0)