Skip to content

Commit 27c500c

Browse files
authored
fix(common): cell range decorator should be hidden after onDragEnd (#923)
- issue was found when user has an Editor open and then click on a row checkbox and start dragging that row checkbox cell, then the cell range decorator appears but never goes away because checkbox plugin has prevents event bubbling when having an editor and in turns wasn't destroying the cell range decorator when it should, the cell range decorator isn't visible but it has a z-index of 9999 and even though it's invisible it was showing on top of everything else making the cell behind it unclickable for the size of the cell range decorator (usually about the size of 2-3 cells)
1 parent 7ac8a62 commit 27c500c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

plugins/slick.cellrangeselector.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,7 @@
352352
}
353353

354354
function handleDragEnd(e, dd) {
355+
_decorator.hide();
355356
if (!_dragging) {
356357
return;
357358
}
@@ -360,7 +361,6 @@
360361
e.stopImmediatePropagation();
361362

362363
stopIntervalTimer();
363-
_decorator.hide();
364364
_self.onCellRangeSelected.notify({
365365
range: new Slick.Range(
366366
dd.range.start.row,

0 commit comments

Comments
 (0)