test: add regression test for duplicate nodes (#56)

Author: jquense

__tests__/dev-expression-test.js

@@ -12,7 +12,7 @@
 let babel = require('@babel/core');
 let devExpression = require('../dev-expression');
 
-function transform(input) {
+function transform(input, plugins) {
   return babel.transform(input, {
     plugins: [devExpression],
   }).code;
@@ -25,7 +25,7 @@ function compare(input, output) {
 
 var oldEnv;
 
-describe('dev-expression', function() {
+describe('dev-expression', function () {
   beforeEach(() => {
     oldEnv = process.env.NODE_ENV;
     process.env.NODE_ENV = '';
@@ -38,56 +38,80 @@ describe('dev-expression', function() {
   describe('__DEV__', () => {
     it('should replace __DEV__ in if', () => {
       compare(
-  `
+        `
   if (__DEV__) {
     console.log('foo')
   }`,
-  `if (process.env.NODE_ENV !== "production") {
+        `if (process.env.NODE_ENV !== "production") {
   console.log('foo');
-}`
+}`,
       );
     });
 
     it('should not replace locally-defined __DEV__', () => {
       compare(
-  `
+        `
   const __DEV__ = false;
 
   if (__DEV__) {
     console.log('foo')
   }`,
-  `const __DEV__ = false;
+        `const __DEV__ = false;
 
 if (__DEV__) {
   console.log('foo');
-}`
+}`,
       );
     });
 
     it('should not replace object key', () => {
       compare(
-  `
+        `
   const foo = {
     __DEV__: 'hey',
   }`,
-  `const foo = {
+        `const foo = {
   __DEV__: 'hey'
-};`
+};`,
       );
     });
   });
 
   it('should replace warning calls', () => {
     compare(
       "warning(condition, 'a %s b', 'c');",
-      `process.env.NODE_ENV !== "production" ? warning(condition, 'a %s b', 'c') : void 0;`
+      `process.env.NODE_ENV !== "production" ? warning(condition, 'a %s b', 'c') : void 0;`,
     );
   });
 
   it('should replace invariant calls', () => {
     compare(
       "invariant(condition, 'a %s b', 'c');",
-      `!condition ? process.env.NODE_ENV !== "production" ? invariant(false, 'a %s b', 'c') : invariant(false) : void 0;`
+      `!condition ? process.env.NODE_ENV !== "production" ? invariant(false, 'a %s b', 'c') : invariant(false) : void 0;`,
     );
   });
+
+  it('should replace invariant correctly when imported and compiled', () => {
+    const code = babel.transform(
+      `
+      import invariant from 'invariant';
+
+      invariant(condition, 'a %s b', 'c');
+    `,
+      {
+        plugins: ['@babel/plugin-transform-modules-commonjs', devExpression],
+      },
+    ).code;
+
+    expect(code).not.toContain('invariant(');
+    expect(code).toMatchInlineSnapshot(`
+      "\\"use strict\\";
+
+      var _invariant = _interopRequireDefault(require(\\"invariant\\"));
+
+      function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+      !condition ? process.env.NODE_ENV !== \\"production\\" ? (0, _invariant.default)(false, 'a %s b', 'c') : (0, _invariant.default)(false) : void 0;"
+    `);
+  });
 });

dev-expression.js

@@ -77,7 +77,7 @@ module.exports = function(babel) {
             // code removal in a minifier will strip that out.
             var condition = node.arguments[0];
             var devInvariant = t.callExpression(
-              node.callee,
+              t.cloneNode(node.callee),
               [t.booleanLiteral(false)].concat(node.arguments.slice(1))
             );
             devInvariant[SEEN_SYMBOL] = true;

package.json

@@ -29,7 +29,9 @@
     "@babel/core": "^7.0.0"
   },
   "devDependencies": {
+    "@babel/plugin-transform-modules-commonjs": "^7.15.4",
     "codecov": "^3.8.1",
-    "jest": "^26.6.3"
+    "jest": "^26.6.3",
+    "prettier": "^2.4.1"
   }
 }