Fix note pad map generation with negative octave

203Null · 203Null · commit af9ef14a5ab4 · 2025-10-01T15:14:55.000-04:00
diff --git a/Applications/Note/NotePad.cpp b/Applications/Note/NotePad.cpp
@@ -52,8 +52,8 @@ Dimension NotePad::GetSize() {
 }
 
 NoteType NotePad::InScale(int16_t note) {
+    note += 120; // add a big pos offset to make sure we don't get negative after mod
     note %= 12;
-    note = abs(note);
 
     if (note == ((rt->config->rootKey + rt->config->rootOffset) % 12))
         return ROOT_NOTE;  // It is a root key

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ Dimension NotePad::GetSize() {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`NoteType NotePad::InScale(int16_t note) {`
	`55`	`+ note += 120; // add a big pos offset to make sure we don't get negative after mod`
`55`	`56`	`note %= 12;`
`56`		`- note = abs(note);`
`57`	`57`
`58`	`58`	`if (note == ((rt->config->rootKey + rt->config->rootOffset) % 12))`
`59`	`59`	`return ROOT_NOTE; // It is a root key`