Skip to content

Commit ec62edf

Browse files
test: enhance error handling and logging in HomePageTest by ensuring initial setup is called and adding screenshot on alert handling failure
1 parent 53ed97e commit ec62edf

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/test_home_page.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def _initial_setup(self): # Removed driver argument
8888
logger.info("Initial alert/overlay button not found or not clickable within timeout, proceeding.")
8989
except Exception as e:
9090
logger.warning(f"An unexpected error occurred while trying to handle initial alert: {e}")
91-
# self._take_screenshot("error_initial_alert_handling") # Optional: screenshot if alert handling fails unexpectedly
91+
self._take_screenshot("error_initial_alert_handling") # Optional: screenshot if alert handling fails unexpectedly
9292

9393
try:
9494
self.wait_long.until(EC.presence_of_element_located((By.CSS_SELECTOR, self.GRADE_INPUT_SELECTOR)))
@@ -213,7 +213,7 @@ def test_us01_add_multiple_valid_grades(self, request=None):
213213
def test_us01_validate_grade_input_below_range(self, request=None):
214214
test_name = request.node.name if request else self._testMethodName
215215
logger.info(f"Running test: {test_name}")
216-
# self._initial_setup() # Already called by self.setUp()
216+
self._initial_setup() # Already called by self.setUp()
217217

218218
initial_item_count = self._get_grades_list_item_count()
219219
self._add_grade_and_percentage("-1.0", "20") # Invalid grade (below min 0)
@@ -228,7 +228,7 @@ def test_us01_validate_grade_input_below_range(self, request=None):
228228
def test_us01_validate_grade_input_above_range(self, request=None):
229229
test_name = request.node.name if request else self._testMethodName
230230
logger.info(f"Running test: {test_name}")
231-
# self._initial_setup()
231+
self._initial_setup()
232232

233233
initial_item_count = self._get_grades_list_item_count()
234234
self._add_grade_and_percentage("8.0", "20") # Invalid grade (above max 7)
@@ -242,7 +242,7 @@ def test_us01_validate_grade_input_above_range(self, request=None):
242242
def test_us01_validate_percentage_input_negative(self, request=None):
243243
test_name = request.node.name if request else self._testMethodName
244244
logger.info(f"Running test: {test_name}")
245-
# self._initial_setup()
245+
self._initial_setup()
246246

247247
initial_item_count = self._get_grades_list_item_count()
248248
self._add_grade_and_percentage("4.0", "-10") # Invalid percentage
@@ -256,7 +256,7 @@ def test_us01_validate_percentage_input_negative(self, request=None):
256256
def test_us01_validate_percentage_input_non_numeric(self, request=None):
257257
test_name = request.node.name if request else self._testMethodName
258258
logger.info(f"Running test: {test_name}")
259-
# self._initial_setup()
259+
self._initial_setup()
260260

261261
initial_item_count = self._get_grades_list_item_count()
262262
self._add_grade_and_percentage("4.0", "abc") # Non-numeric percentage

0 commit comments

Comments
 (0)