chore: update SonarQube integration in CI workflow with improved setup and dependencies

Author: 02loveslollipop

.github/workflows/python-selenium-ci-workflow.yaml

@@ -17,30 +17,37 @@ on:
 
 
 jobs:
-  # sonarcloud:
-  #   runs-on: ubuntu-latest
-  #   env:
-  #     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  #     SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-  #   permissions:
-  #     contents: read
-  #   steps:
-  #     - name: Checkout code
-  #       uses: actions/checkout@v2
-
-  #     - name: SonarCloud Scan
-  #       uses: sonarsource/sonarcloud-github-action@master
-  #       with:
-  #         args: sonar-scanner -Dsonar.projectKey=your_project_key -Dsonar.organization=your_organization_name -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=${{ secrets.SONAR_TOKEN }}
-  #       env:
-  #         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  #         SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+  sonarqube:
+    name: SonarQube
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '18'
+          cache: 'npm'
+          cache-dependency-path: react/package-lock.json
+
+      - name: Run npm install
+        run: |
+          cd react
+          npm ci
+
+      - name: SonarQube Scan
+        uses: SonarSource/sonarqube-scan-action@v5
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
   selenium:
     runs-on: ubuntu-latest
+    needs: sonarqube
 
     env:
-      APP_URL: ${{ secrets.APP_URL || 'http://localhost:3000' }}
+      APP_URL: 'http://localhost:3000'
       DISPLAY: :99
 
     steps:
@@ -106,7 +113,7 @@ jobs:
         # Add HTML report generation
         python -m pytest -v test_home_page.py --html=report.html
       env:
-        APP_URL: ${{ secrets.APP_URL || 'http://localhost:3000' }}
+        APP_URL: 'http://localhost:3000'
         PYTHONPATH: ${{ github.workspace }}
 
     - name: Upload test results

tests/test_home_page.py

@@ -69,8 +69,7 @@ def test_home_page_functional_flow(self, driver):
             )
             final_grade_rows = driver.find_elements(By.CSS_SELECTOR, ".home__grade-row")
             assert len(final_grade_rows) == initial_count, "Grade row was not removed!"
-            
-            assert True == False, "Intentional failure to test screenshot functionality." #TODO: Remove this line after testing
+
 
         except Exception as e:
             # Take screenshot on any failure