Skip to content

Commit ea0a88c

Browse files
authored
FIX: services not in updates.json failing update service script (#2204)
* FIX: services not in updates.json failing update service script * FIX: Client Selection for MEV Preset * FIX: Reth Fullnode Mode
1 parent 6b4da2b commit ea0a88c

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

controls/roles/update-services/tasks/update-service.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,15 @@
1717

1818
- name: Get latest version for this service
1919
set_fact:
20-
new_service_docker_image_tag: "{{ (update_data.json[service_configuration.network][service_configuration.service] | default(update_data.json['mainnet'][service_configuration.service] | default([]))) | last }}"
21-
when: service_configuration.autoupdate and service_configuration.service != 'CustomService'
20+
new_service_docker_image_tag: "{{ (update_data.json.get(service_configuration.network, {}).get(service_configuration.service, update_data.json.get('mainnet', {}).get(service_configuration.service, []))) | last | default(None, true) }}" # Returns empty string if nothing is found. (don't ask me why default is not picking up and returning None)
21+
when:
22+
- service_configuration.autoupdate
23+
- service_configuration.service != 'CustomService'
2224

2325
- name: Build new image tag
2426
set_fact:
2527
new_service_configuration_fraction:
26-
image: "{{ service_docker_image }}:{{ new_service_docker_image_tag | default(service_docker_image_tag) }}"
28+
image: "{{ service_docker_image }}:{{ new_service_docker_image_tag | default(service_docker_image_tag, true) }}" # If new_service_docker_image_tag is falsy, use the current tag (will cause a restart if the tag is an empty string)
2729
when: service_configuration.autoupdate
2830

2931
- name: Update configuration

launcher/src/backend/OneClickInstall.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ export class OneClickInstall {
323323
}
324324

325325
handleArchiveTags(selectedPreset) {
326-
if (selectedPreset == "staking") {
326+
if (/mev boost|staking/.test(selectedPreset)) {
327327
switch (this.executionClient.service) {
328328
case "RethService":
329329
this.executionClient.command.push("--full");

launcher/src/components/UI/one-click/components/plugin/ConfigBody.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ const checkPluginCategory = (element) => {
137137
let filter;
138138
switch (clickStore.selectedPreset.name) {
139139
case "lidocsm":
140+
case "mev boost":
140141
case "staking":
141142
filter = (item) => item.category === element.category && !/(SSVNetwork|Web3Signer|Charon)/.test(item.service);
142143
if (manageStore.currentNetwork.network == "gnosis") {
@@ -171,9 +172,6 @@ const checkPluginCategory = (element) => {
171172
case "rocketpool":
172173
//filter = (item) => item.category === element.category
173174
break;
174-
case "mev boost":
175-
filter = (item) => item.category === element.category && !/(SSVNetwork|Reth|Web3Signer|Charon)/.test(item.service);
176-
break;
177175
case "stereum on arm":
178176
filter = (item) => item.category === element.category && !/(Prysm|Reth|SSVNetwork|Web3Signer|Charon)/.test(item.service);
179177
if (manageStore.currentNetwork.network == "gnosis") {

0 commit comments

Comments
 (0)