[BUG] restart rollout-strategy doesn't do anything

[AlexandreFigueired0]

Describe the bug
While testing the different values for rollout-strategy annotation ("rollout" and "restart"), the "restart" value presented the same behaviour as the default "rollout".

To Reproduce
Add the annotation reloader.stakater.com/rollout-strategy: "restart" to your workload metadata. Trigger reloads and, on the running workload, verify that the pod template of your workload was modified, according to the strategy you set with --reload-strategy

Expected behavior
With the rollout-strategy annotation set to "restart", I would expect a restart of the workload without any internal configuration (yaml) change.

Environment

• Kubernetes/OpenShift Version: v1.34.2

[TheiLLeniumStudios]

@AlexandreFigueired0 The docs are a bit confusing. The rollout-strategy annotation is actually only applicable for Argo rollouts

[rasheedamir]

@TheiLLeniumStudios which docs are you referring to? We should fix the documentation so, we remove thus confusion completely

[TheiLLeniumStudios]

@rasheedamir this one in the readme:
https://github.com/stakater/Reloader?tab=readme-ov-file#4-%EF%B8%8F-workload-specific-rollout-strategy

Even though it is specific to argo rollouts, the annotation string itself doesn't indicate it and the text is also not pretty clear as it doesn't indicate that its only for argo rollouts. The actual fix is to not just update the readme but also change the annotation to something like reloader.stakater.com/argo-rollout-strategy instead but that will be a breaking change

[rasheedamir]

ok we should start with clarifying the docs and then I agree we should look into all annotations and see what we can improve; we can add new annotation and keep the old one but depreciate it and remove it after few releases; if a user uses the old one we should log and tell the user to use the other annotation

[rasheedamir]

@faizanahmad055 can you update the readme plz to reflect this?