-
-
Notifications
You must be signed in to change notification settings - Fork 619
Description
Describe the bug
Reloader no longer supports Autoreload (reloader.stakater.com/auto: "true") + Named resourced reload annotations (configmap.reloader.stakater.com/reload: "my-config") at the same time.
That means, before v1.4.6 you could add both annotations on a resource and it automatically restarted the service when dependent configmap was updated (autoreload) and also when a configmap referenced in configmap.reloader.stakater.com/reload: "my-config" was changed.
After refactor done in v1.4.6 (PR 966) configmap.reloader.stakater.com/reload: "my-config" annotation is ignored if reloader.stakater.com/auto: "true" is also set.
To Reproduce
Reloader => v1.4.6
Add both annotations to a resource:
configmap.reloader.stakater.com/reload: "my-config"
reloader.stakater.com/auto: "true"
Change the configmap specified in first annotation (this configmap must not be a dependency of the resource, it has to be external).
After that resource will mark the changes as ShouldReload: false --> "No changes detected in ..."
Expected behavior
It should work the same as it did before, kinda like an OR statement, it should check if any dependent (autoreload) or externally referenced configmaps/secrets via annotation have changed.
Environment
- Operator Version: => v1.4.6
- Kubernetes/OpenShift Version: 1.32
Additional context
Also from version v1.4.6 upwards I've seen duplicated logs for "No changes detected in...", when I believe it should only show once.
time="2025-11-20T15:29:22Z" level=debug msg="No changes detected in 'cluster-autoscaler-status' of type 'CONFIGMAP' in namespace 'kube-system'"
time="2025-11-20T15:29:22Z" level=debug msg="No changes detected in 'cluster-autoscaler-status' of type 'CONFIGMAP' in namespace 'kube-system'"
time="2025-11-20T15:29:22Z" level=debug msg="No changes detected in 'cluster-autoscaler-status' of type 'CONFIGMAP' in namespace 'kube-system'"
time="2025-11-20T15:29:22Z" level=debug msg="No changes detected in 'cluster-autoscaler-status' of type 'CONFIGMAP' in namespace 'kube-system'"
time="2025-11-20T15:29:22Z" level=debug msg="No changes detected in 'cluster-autoscaler-status' of type 'CONFIGMAP' in namespace 'kube-system'"
....