Erroneous tag deletion with the rename option in the alphabetical tag list page

[cy7yz2rj]

Shaarli v0.14.0, steps to reproduce:

1. Open the alphabetical tag list /tags/list?sort=alpha
2. Click the edit tag button to rename /admin/tags?fromtag=EXAMPLE
3. Confirm without making any changes
4. EXAMPLE tag removed from all bookmarks tagged with it, as if the delete option was chosen

I nuked quite a few tags accidentally while tidying up before I realised the bug existence, is there a simple way to recover the deletions from history.php?

[nodiscc]

Looks like a bug indeed. I'm not sure what the proper behavior would be. Return an error when New name is blank?

is there a simple way to recover the deletions

Backups :)

[cy7yz2rj]

I think there's a misunderstanding, I'm not referring to the Manage Tags page available under Tools, I mean the clickable blue and white square icon between the red rubbish bin icon and the tag count and name in the exhaustive alphabetical tag list page, accessible by clicking on Tag cloud then Alphabetical.

The issue is that opening the editable field by clicking the blue icon then confirming without making any changes is by itself enough to trigger deletion.

If someone misclicks, the only safe ways to leave are:

1. force a unwanted rename (and possibly revert it immediately after), or
2. reload page/navigate back in the web browser.

Simply confirming the existing name will remove the tag, it is not necessary to blank the text input field.

IMO the proper behaviour would be to leave the tag as is, since no edits were made; blanking leading to deletion would be acceptable, deletion when the same name is kept is very unexpected.

EDIT: For example, in the main Shaarli page, clicking the very same blue square icon to edit an existing boookmark, then clicking Apply Changes in the Edit Shaare page without making any edits in any of the fields will not delete the bookmark, the same thing should happen in the alphabetical tag list page.

[nodiscc]

Thank you, I misread your initial report, now I understand and I've been able to reproduce this on https://demo.shaarli.org/tags/list?sort=alpha

As you said, the expected behavior would be to keep the tag unchanged when no edits to the tag name have been made.

Currently simply clicking the blue Edit button for a tag, and validating changes right away causes the tag to be deleted (even if the original tag name still appears in the edit text field)

Edit: the tag list view was introduced in #835 and I don't think much has changed since then