chore(tests): Refactor tests for idiomatic Go and minor improvements (#3561)

* all: Refactor tests for idiomatic Go and minor improvements

Replaced redundant 'for key, _' with 'for key' in map iterations for clarity in doctests/cmds_hash_test.go. Updated time measurement from time.Now().Sub to time.Since in hset_benchmark_test.go for idiomatic Go usage. Simplified variadic argument types from interface{} to any and removed unused min function in maintnotifications/e2e/utils_test.go.

* maintnotifications/e2e/utils_test: Update variadic args type in printLog function

Changed the variadic argument type in printLog from 'any' to 'interface{}' for compatibility and consistency with standard Go practices.

Author: 12ya

doctests/cmds_hash_test.go

@@ -79,7 +79,7 @@ func ExampleClient_hset() {
 
 	keys := make([]string, 0, len(res6))
 
-	for key, _ := range res6 {
+	for key := range res6 {
 		keys = append(keys, key)
 	}
 
@@ -186,7 +186,7 @@ func ExampleClient_hgetall() {
 
 	keys := make([]string, 0, len(hGetAllResult2))
 
-	for key, _ := range hGetAllResult2 {
+	for key := range hGetAllResult2 {
 		keys = append(keys, key)
 	}
 

hset_benchmark_test.go

@@ -86,7 +86,7 @@ func benchmarkHSETOperations(b *testing.B, rdb *redis.Client, ctx context.Contex
 				b.Fatalf("HSET operation failed: %v", err)
 			}
 		}
-		totalTimes = append(totalTimes, time.Now().Sub(startTime))
+		totalTimes = append(totalTimes, time.Since(startTime))
 	}
 
 	// Stop the timer to calculate metrics
@@ -164,7 +164,7 @@ func benchmarkHSETPipelined(b *testing.B, rdb *redis.Client, ctx context.Context
 		if err != nil {
 			b.Fatalf("Pipeline execution failed: %v", err)
 		}
-		totalTimes = append(totalTimes, time.Now().Sub(startTime))
+		totalTimes = append(totalTimes, time.Since(startTime))
 	}
 
 	b.StopTimer()

maintnotifications/e2e/utils_test.go

@@ -43,13 +43,6 @@ func containsSubstring(s, substr string) bool {
 	return false
 }
 
-func min(a, b int) int {
-	if a < b {
-		return a
-	}
-	return b
-}
-
 func printLog(group string, isError bool, format string, args ...interface{}) {
 	_, filename, line, _ := runtime.Caller(2)
 	filename = filepath.Base(filename)