allow_edits=1 in docker makes '/data' read only

[kjames2001]

docker runs well, i can serve files in /data, and logs shows its running in '+ Read/Write'.

i turned on allow edits by adding environment variable: '-e PUP_ALLOW_EDITS=1' to docker run command.

webui add buttons for creating folder and upload files, but get a permission denied message. logs says its running in '+ Read Only'.

[kjames2001]

neat app btw!

[proofrock]

Thanks! I'll try to reproduce this and - of course - fix it.

[proofrock]

Can you confirm that it's only in the root? I can see that it's impossible e.g. to create a folder there, but it seems fine in a subpath. This should be related to the Dockerfile not setting the correct permissions of the /data folder. Then there would be an additional bug - + Read Only shouldn't be shown. I'll investigate better in the afternoon.

[kjames2001]

thanks for looking into it so soon!

i can confirm your find. its only in the root, subfolders works fine.

[proofrock]

Ahem... should be the other way around 🙄

[marioscube]

Installed pupcloud on Docker last night.
User the pre-build version. Building myself threw an error on make.

I can create a folder/directory in the pupcloud root, and anywhere else.

Looks like a permission problem outside of Docker.

[proofrock]

That is really strange. It doesn't work for me. Anyways, setting the proper ownership of the /data dir wouldn't hurt, and the dockerfile doesn't do it, so... I'll make the change, and if you and @kjames2001 could test it again, that would be great.

Also, which error do you get while building the docker? Feel free to file a separate issue if you feel that it isn't some kind of quirk of your system.

[marioscube]

I start pupcloud on docker with:
-p 17178:17178
-p 17179:17179
-v /home/user/Docker/pupcloud:/data
-e PID=1000
-e PGID=1000
-e PUP_PASSWORD=ciao
-e PUP_ALLOW_EDITS=1 \

~/Docker$ ls -l
drwxr-xr-x 3 user user 4096 May 9 10:41 pupcloud

~/Docker$ id 1000
uid=1000(user) gid=1000(user)

I will try new docker image if available.

[proofrock]

I see. And I noticed that my test wasn't accurate, I couldn't write in the directory I was mapping even from "outside" docker and pupcloud, so no wonder I couldn't from "inside". @kjames2001 which user are you specifying for PUID and PGID (if any); and which user/group owns the folder you're mapping?

@marioscube you may want to use PUID, not PID