Skip to content

Commit 8fd625b

Browse files
tobiutobiu
committed
ticket sync
1 parent a9b7d98 commit 8fd625b

File tree

4 files changed

+40
-15
lines changed

4 files changed

+40
-15
lines changed

‎.github/.sync-metadata.json‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"lastSync": "2025-12-28T00:03:40.537Z",
3-
"releasesLastFetched": "2025-12-28T00:03:40.944Z",
2+
"lastSync": "2025-12-28T11:42:58.613Z",
3+
"releasesLastFetched": "2025-12-28T11:42:59.119Z",
44
"pushFailures": [],
55
"issues": {
66
"3789": {
@@ -13188,15 +13188,15 @@
1318813188
"state": "OPEN",
1318913189
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8160.md",
1319013190
"closedAt": null,
13191-
"updatedAt": "2025-12-27T21:00:50Z",
13192-
"contentHash": "5283948339d23c17f7ebd83373e6608def8e80a471a52f3eed52ee36531826b5"
13191+
"updatedAt": "2025-12-28T00:07:45Z",
13192+
"contentHash": "177c6a6720ca62e691fdbf661e32757ab4a6c5009017fcbca89237f0e7010c07"
1319313193
},
1319413194
"8161": {
13195-
"state": "OPEN",
13195+
"state": "CLOSED",
1319613196
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8161.md",
13197-
"closedAt": null,
13198-
"updatedAt": "2025-12-27T23:53:54Z",
13199-
"contentHash": "c8cb6980e23c0facefc6aefab20736f56b899022d3b166a9df33234cc5ceb3cb"
13197+
"closedAt": "2025-12-28T00:07:22Z",
13198+
"updatedAt": "2025-12-28T00:07:22Z",
13199+
"contentHash": "9181888b53d9900f1d1e646ab5980351f616fb524e6c10d9d3463beb223de786"
1320013200
},
1320113201
"8162": {
1320213202
"state": "OPEN",
@@ -13210,7 +13210,7 @@
1321013210
"path": "/Users/Shared/github/neomjs/neo/.github/ISSUE/issue-8163.md",
1321113211
"closedAt": null,
1321213212
"updatedAt": "2025-12-27T22:48:29Z",
13213-
"contentHash": "5a9dd605cb75632bb487a75fb0f3a9f20b7cc740a50b0ac8cccd425f37b790c4"
13213+
"contentHash": "80018898f6492286d380ceee151d24ff87857e8c0ac8d930d1f5307fcb2befc3"
1321413214
},
1321513215
"8164": {
1321613216
"state": "CLOSED",

‎.github/ISSUE/issue-8160.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ state: OPEN
55
labels:
66
- enhancement
77
- ai
8-
assignees: []
8+
assignees:
9+
- tobiu
910
createdAt: '2025-12-27T21:00:50Z'
10-
updatedAt: '2025-12-27T21:00:50Z'
11+
updatedAt: '2025-12-28T00:07:45Z'
1112
githubUrl: 'https://github.com/neomjs/neo/issues/8160'
1213
author: tobiu
1314
commentsCount: 0
@@ -32,4 +33,6 @@ Currently, `Neo.draggable.container.SortZone` uses the same intersection logic (
3233
- 2025-12-27 @tobiu added the `enhancement` label
3334
- 2025-12-27 @tobiu added the `ai` label
3435
- 2025-12-27 @tobiu added parent issue #8163
36+
- 2025-12-28 @tobiu assigned to @tobiu
37+
- 2025-12-28 @tobiu referenced in commit `9a7d24f` - "Decouple and Configure Window Detachment Thresholds in SortZone #8160 wip"
3538

‎.github/ISSUE/issue-8161.md‎

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,24 @@
11
---
22
id: 8161
33
title: Refine Cross-Window Drag Intersection to Target SortZone Rect
4-
state: OPEN
4+
state: CLOSED
55
labels:
66
- enhancement
77
- ai
88
assignees:
99
- tobiu
1010
createdAt: '2025-12-27T21:06:24Z'
11-
updatedAt: '2025-12-27T23:53:54Z'
11+
updatedAt: '2025-12-28T00:07:22Z'
1212
githubUrl: 'https://github.com/neomjs/neo/issues/8161'
1313
author: tobiu
14-
commentsCount: 0
14+
commentsCount: 1
1515
parentIssue: 8163
1616
subIssues: []
1717
subIssuesCompleted: 0
1818
subIssuesTotal: 0
1919
blockedBy: []
2020
blocking: []
21+
closedAt: '2025-12-28T00:07:22Z'
2122
---
2223
# Refine Cross-Window Drag Intersection to Target SortZone Rect
2324

@@ -34,11 +35,32 @@ Dragging an item into a window's blank space, headers, or even DevTools area (if
3435
**Goal:**
3536
Update `DragCoordinator` (or delegate to `SortZone`) to verify that the drag coordinates (or proxy rect) actually intersect with the target `SortZone`'s `ownerRect` before initiating the remote drag sequence. This ensures the "drop target" effect only activates when visually appropriate.
3637

38+
## Comments
39+
40+
### @tobiu - 2025-12-28 00:03
41+
42+
**Input from gemini:**
43+
44+
> ✦ I have implemented the enhanced intersection logic for cross-window drag operations.
45+
>
46+
> **Key Changes:**
47+
>
48+
> 1. **`Neo.draggable.dashboard.SortZone`:**
49+
> * Added `acceptsRemoteDrag(localX, localY)`: This method performs a precise point-in-rect check against the dashboard's `ownerRect`. It handles lazy fetching of the DOM rect if it's not already cached, ensuring the first interaction is handled correctly (albeit asynchronously for the first frame).
50+
>
51+
> 2. **`Neo.manager.DragCoordinator`:**
52+
> * Refactored `onDragMove` to use this new validation method.
53+
> * **Crucially**, it now waits for `acceptsRemoteDrag` to return `true` before suspending the source window drag (closing the popup). This prevents the "disappearing item" issue when dragging over window headers or empty space.
54+
> * Cleaned up the control flow to use early returns, removing deeply nested `else` blocks.
55+
>
56+
> This ensures that the "drop target" effect and the handover of control only happen when the user clearly intends to drop onto a valid dashboard area.
57+
3758
## Activity Log
3859

3960
- 2025-12-27 @tobiu added the `enhancement` label
4061
- 2025-12-27 @tobiu added the `ai` label
4162
- 2025-12-27 @tobiu added parent issue #8163
4263
- 2025-12-27 @tobiu assigned to @tobiu
4364
- 2025-12-28 @tobiu referenced in commit `711a59b` - "Neo.manager.DragCoordinator: Refactor onDragMove for clarity and efficient early returns - #8161"
65+
- 2025-12-28 @tobiu closed this issue
4466

‎.github/ISSUE/issue-8163.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ subIssues:
2222
- 8165
2323
- 8166
2424
- 8167
25-
subIssuesCompleted: 1
25+
subIssuesCompleted: 2
2626
subIssuesTotal: 7
2727
blockedBy: []
2828
blocking: []

0 commit comments

Comments
 (0)