#8149 ensuring all "main.DomAccess" related remote calls pass windowId

tobiu · tobiu · commit 51df23ad6916 · 2025-12-21T13:54:08.000+01:00
diff --git a/apps/covid/view/MainContainerController.mjs b/apps/covid/view/MainContainerController.mjs
@@ -341,9 +341,10 @@ class MainContainerController extends ComponentController {
         let me = this;
 
         Neo.main.DomAccess.addScript({
-            async: true,
-            defer: true,
-            src  : 'https://buttons.github.io/buttons.js'
+            async   : true,
+            defer   : true,
+            src     : 'https://buttons.github.io/buttons.js',
+            windowId: me.windowId
         });
 
         me.getReference('tab-container').on('moveTo', me.onTabMove, me)
diff --git a/apps/covid/view/country/Table.mjs b/apps/covid/view/country/Table.mjs
@@ -133,7 +133,7 @@ class Table extends Container {
                 if (!selectionModel.isSelected(id)) {
                     selectionModel.select(id);
 
-                    me.mounted && Neo.main.DomAccess.scrollToTableRow({id: id})
+                    me.mounted && Neo.main.DomAccess.scrollToTableRow({id, windowId: me.windowId})
                 }
             } else {
                 selectionModel.deselectAll()
diff --git a/apps/realworld/view/article/CreateCommentComponent.mjs b/apps/realworld/view/article/CreateCommentComponent.mjs
@@ -120,7 +120,8 @@ class CreateCommentComponent extends Component {
         // we could register an oninput event to this view as well and store the changes
         Neo.main.DomAccess.getAttributes({
             id        : me.getInputElId(),
-            attributes: 'value'
+            attributes: 'value',
+            windowId  : me.windowId
         }).then(data => {
             me.getController().postComment({
                 data: JSON.stringify({
@@ -130,9 +131,9 @@ class CreateCommentComponent extends Component {
                 })
             }).then(data => {
                 me.vdom.cn[0].cn[0].value = ''; // reset the textarea value
-                me.update();
-            });
-        });
+                me.update()
+            })
+        })
     }
 }
 
diff --git a/apps/realworld/view/article/CreateComponent.mjs b/apps/realworld/view/article/CreateComponent.mjs
@@ -193,7 +193,8 @@ class CreateComponent extends Component {
         if (event.key === 'Enter') {
             Neo.main.DomAccess.getAttributes({
                 id        : event.target.id,
-                attributes: 'value'
+                attributes: 'value',
+                windowId  : me.windowId
             }).then(data => {
                 VNodeUtil.find(me.vnode, {className: 'field-tags'}).vnode.attributes.value = data.value;
                 me.tagList = [...me._tagList, data.value];
@@ -218,7 +219,8 @@ class CreateComponent extends Component {
 
         Neo.main.DomAccess.getAttributes({
             id        : ids,
-            attributes: 'value'
+            attributes: 'value',
+            windowId  : me.windowId
         }).then(data => {
             ArticleApi[me.slug ? 'put' : 'post']({
                 data: JSON.stringify({
diff --git a/apps/realworld/view/user/SettingsComponent.mjs b/apps/realworld/view/user/SettingsComponent.mjs
@@ -203,7 +203,8 @@ class SettingsComponent extends Component {
 
         Neo.main.DomAccess.getAttributes({
             id        : [bio.id, email.id, image.id, password.id, userName.id],
-            attributes: 'value'
+            attributes: 'value',
+            windowId  : me.windowId
         }).then(data => {
             me.getController().updateSettings({
                 data: JSON.stringify({
diff --git a/apps/realworld/view/user/SignUpComponent.mjs b/apps/realworld/view/user/SignUpComponent.mjs
@@ -199,7 +199,8 @@ class SignUpComponent extends Component {
         // we could register an oninput event to this view as well and store the changes
         Neo.main.DomAccess.getAttributes({
             id        : ids,
-            attributes: 'value'
+            attributes: 'value',
+            windowId  : me.windowId
         }).then(data => {
             userData = {
                 user: {
diff --git a/apps/sharedcovid/view/MainContainerController.mjs b/apps/sharedcovid/view/MainContainerController.mjs
@@ -527,9 +527,10 @@ class MainContainerController extends ComponentController {
         let me = this;
 
         Neo.main.DomAccess.addScript({
-            async: true,
-            defer: true,
-            src  : 'https://buttons.github.io/buttons.js'
+            async   : true,
+            defer   : true,
+            src     : 'https://buttons.github.io/buttons.js',
+            windowId: me.windowId
         });
 
         me.getReference('tab-container').on('moveTo', me.onTabMove, me)
diff --git a/apps/sharedcovid/view/country/Table.mjs b/apps/sharedcovid/view/country/Table.mjs
@@ -133,7 +133,7 @@ class Table extends Container {
                 if (!selectionModel.isSelected(id)) {
                     selectionModel.select(id);
 
-                    me.mounted && Neo.main.DomAccess.scrollToTableRow({id: id})
+                    me.mounted && Neo.main.DomAccess.scrollToTableRow({id, windowId: me.windowId})
                 }
             } else {
                 selectionModel.deselectAll()
diff --git a/examples/component/coronaGallery/Viewport.mjs b/examples/component/coronaGallery/Viewport.mjs
@@ -257,8 +257,9 @@ class Viewport extends BaseViewport {
     construct(config) {
         super.construct(config);
 
-        let me  = this,
-            url = Neo.config.useFallbackApi ?
+        let me         = this,
+            {windowId} = me,
+            url        = Neo.config.useFallbackApi ?
                 'https://raw.githubusercontent.com/neomjs/pages/main/resources_pub/data/cvid_static_countries.json' :
                 'https://disease.sh/v3/covid-19/countries';
 
@@ -278,17 +279,18 @@ class Viewport extends BaseViewport {
             .then(data => me.addStoreItems(data));
 
         Neo.Main.setNeoConfig({
-            key     : 'renderCountDeltas',
-            value   : true,
-            windowId: me.windowId
+            key  : 'renderCountDeltas',
+            value: true,
+            windowId
         });
 
         if (me.showGitHubStarButton) {
             me.on('mounted', () => {
                 Neo.main.DomAccess.addScript({
                     async: true,
                     defer: true,
-                    src  : 'https://buttons.github.io/buttons.js'
+                    src  : 'https://buttons.github.io/buttons.js',
+                    windowId
                 })
             })
         }
diff --git a/examples/component/coronaHelix/MainContainer.mjs b/examples/component/coronaHelix/MainContainer.mjs
@@ -429,9 +429,10 @@ class MainContainer extends Viewport {
         if (me.showGitHubStarButton) {
             me.on('mounted', () => {
                 Neo.main.DomAccess.addScript({
-                    async: true,
-                    defer: true,
-                    src  : 'https://buttons.github.io/buttons.js'
+                    async   : true,
+                    defer   : true,
+                    src     : 'https://buttons.github.io/buttons.js',
+                    windowId: me.windowId
                 })
             })
         }
diff --git a/examples/component/gallery/MainContainer.mjs b/examples/component/gallery/MainContainer.mjs
@@ -234,9 +234,10 @@ class MainContainer extends Viewport {
         if (me.showGitHubStarButton) {
             me.on('mounted', () => {
                 Neo.main.DomAccess.addScript({
-                    async: true,
-                    defer: true,
-                    src  : 'https://buttons.github.io/buttons.js'
+                    async   : true,
+                    defer   : true,
+                    src     : 'https://buttons.github.io/buttons.js',
+                    windowId: me.windowId
                 })
             })
         }
diff --git a/examples/component/video/MainContainerController.mjs b/examples/component/video/MainContainerController.mjs
@@ -20,15 +20,15 @@ class MainContainerController extends ComponentController {
      * @param {Object} config
      */
     onToggleTheme(config) {
-        const
-            add         = (this.theme === 'light') ? 'dark' : 'light',
+        let me          = this,
+            add         = (me.theme === 'light') ? 'dark' : 'light',
             remove      = add === 'light' ? 'dark' : 'light',
-            themeButton = this.getReference('theme-button'),
+            themeButton = me.getReference('theme-button'),
             buttonIcon  = add === 'light' ? 'sun' : 'moon';
 
-        this.theme = add;
+        me.theme = add;
 
-        Neo.main.DomAccess.setBodyCls({remove: ['neo-theme-' + remove] , add: ['neo-theme-' + add]});
+        Neo.main.DomAccess.setBodyCls({remove: ['neo-theme-' + remove] , add: ['neo-theme-' + add], windowId: me.windowId});
         themeButton.iconCls = 'fa fa-' + buttonIcon
     }
 }
diff --git a/examples/dialog/MainContainer.mjs b/examples/dialog/MainContainer.mjs
@@ -163,8 +163,9 @@ class MainContainer extends Viewport {
         }
 
         Neo.main.DomAccess.setBodyCls({
-            add   : [theme],
-            remove: [oldTheme]
+            add     : [theme],
+            remove  : [oldTheme],
+            windowId: this.windowId
         });
 
         button.set({
diff --git a/src/calendar/view/month/Component.mjs b/src/calendar/view/month/Component.mjs
@@ -330,7 +330,8 @@ class Component extends BaseComponent {
                     Neo.main.DomAccess.scrollTo({
                         direction: 'top',
                         id       : me.vdom.cn[1].id,
-                        value    : data[0].height - data[1].height
+                        value    : data[0].height - data[1].height,
+                        windowId : me.windowId
                     })
                 })
             })
@@ -704,7 +705,8 @@ class Component extends BaseComponent {
                     Neo.main.DomAccess.scrollTo({
                         direction: 'top',
                         id       : me.vdom.cn[1].id,
-                        value    : data.clientHeight - me.headerHeight
+                        value    : data.clientHeight - me.headerHeight,
+                        windowId : me.windowId
                     })
                 })
             }
diff --git a/src/calendar/view/week/Component.mjs b/src/calendar/view/week/Component.mjs
@@ -471,7 +471,8 @@ class Component extends BaseComponent {
                 appName  : me.appName,
                 direction: 'left',
                 id       : scrollContainerId,
-                value    : rect.width * me.columnsBuffer / me.columnsVisible / 3
+                value    : rect.width * me.columnsBuffer / me.columnsVisible / 3,
+                windowId : me.windowId
             })
         }
     }
@@ -819,7 +820,8 @@ class Component extends BaseComponent {
                     Neo.main.DomAccess.scrollBy({
                         direction: 'left',
                         id       : me.getScrollContainer().id,
-                        value    : scrollValue
+                        value    : scrollValue,
+                        windowId : me.windowId
                     }).then(() => {
                         me.isUpdating = false
                     })
diff --git a/src/component/Base.mjs b/src/component/Base.mjs
@@ -1210,11 +1210,11 @@ class Component extends Abstract {
     /**
      * Convenience shortcut
      * @param {String[]|String} id=this.id
-     * @param {String} appName=this.appName
+     * @param {String} windowId=this.windowId
      * @returns {Promise<Neo.util.Rectangle|Neo.util.Rectangle[]>}
      */
-    async getDomRect(id=this.id, appName=this.appName) {
-        let result = await Neo.main.DomAccess.getBoundingClientRect({appName, id, windowId: this.windowId});
+    async getDomRect(id=this.id, windowId=this.windowId) {
+        let result = await Neo.main.DomAccess.getBoundingClientRect({id, windowId});
 
         if (Array.isArray(result)) {
             return result.map(rect => Rectangle.clone(rect))
diff --git a/src/container/Viewport.mjs b/src/container/Viewport.mjs
@@ -62,10 +62,9 @@ class Viewport extends Container {
     onConstructed() {
         super.onConstructed();
 
-        let {appName, windowId} = this;
+        let {windowId} = this;
 
         this.applyBodyCls && Neo.main.DomAccess.applyBodyCls({
-            appName,
             cls: ['neo-body-viewport'],
             windowId
         })
diff --git a/src/draggable/grid/header/toolbar/SortZone.mjs b/src/draggable/grid/header/toolbar/SortZone.mjs
@@ -96,7 +96,7 @@ class SortZone extends BaseSortZone {
                 Neo.main.DomAccess.scrollTo({
                     id      : bodyWrapperId,
                     value   : body.scrollTop,
-                    windowId: this.windowId
+                    windowId: me.windowId
                 })
             }
         };
diff --git a/src/form/field/TextArea.mjs b/src/form/field/TextArea.mjs
@@ -176,7 +176,6 @@ class TextArea extends Text {
         if (me.autoGrow && me.mounted && me.readOnly) {
             me.timeout(50).then(() => {
                 Neo.main.DomAccess.monitorAutoGrowHandler({
-                    appName : me.appName,
                     id      : inputEl.id,
                     windowId: me.windowId
                 })
@@ -214,9 +213,9 @@ class TextArea extends Text {
         if (me.mounted && me.autoGrow) {
             // Delegate monitoring of sizes to the main thread.
             Neo.main.DomAccess.monitorAutoGrow({
-                appName  : me.appName,
                 id       : me.getInputElId(),
                 autoGrow : me.autoGrow
+                windowId : me.windowId
             })
         }
     }
diff --git a/src/grid/ScrollManager.mjs b/src/grid/ScrollManager.mjs
@@ -77,7 +77,7 @@ class ScrollManager extends Base {
             touchcancel: me.onTouchCancel,
             touchend   : me.onTouchEnd,
             scope      : me
-        });
+        })
     }
 
     /**
@@ -108,7 +108,8 @@ class ScrollManager extends Base {
                 deltaX !== 0 && Neo.main.DomAccess.scrollTo({
                     direction: 'left',
                     id       : me.gridContainer.id,
-                    value    : me.scrollLeft + deltaX
+                    value    : me.scrollLeft + deltaX,
+                    windowId : me.windowId
                 })
 
                 me.lastTouchX = lastTouchX
@@ -156,7 +157,8 @@ class ScrollManager extends Base {
                     deltaY !== 0 && Neo.main.DomAccess.scrollTo({
                         direction: 'top',
                         id       : body.vdom.id,
-                        value    : me.scrollTop + deltaY
+                        value    : me.scrollTop + deltaY,
+                        windowId : me.windowId
                     })
 
                     me.lastTouchY = lastTouchY
diff --git a/src/plugin/PrefixField.mjs b/src/plugin/PrefixField.mjs
@@ -219,7 +219,7 @@ class PrefixField extends Plugin {
         el.value = clean(value).join``;
         me.ignoreSelection = true;
 
-        Neo.main.DomAccess.selectNode({id: el.getInputElId(), start: i, end: j});
+        Neo.main.DomAccess.selectNode({id: el.getInputElId(), start: i, end: j, windowId: this.owner.windowId});
         me.ignoreSelection = false;
 
         me.back = false
diff --git a/src/table/Body.mjs b/src/table/Body.mjs
@@ -365,7 +365,7 @@ class TableBody extends Component {
         me.promiseUpdate().then(() => {
             if (selectedRows?.length > 0) {
                 // this logic only works for selection.table.RowModel
-                Neo.main.DomAccess.scrollToTableRow({appName: me.appName, id: selectedRows[0]})
+                Neo.main.DomAccess.scrollToTableRow({id: selectedRows[0], windowId: me.windowId})
             }
         })
     }

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ class Table extends Container {`
`133`	`133`	`if (!selectionModel.isSelected(id)) {`
`134`	`134`	`selectionModel.select(id);`
`135`	`135`
`136`		`- me.mounted && Neo.main.DomAccess.scrollToTableRow({id: id})`
	`136`	`+ me.mounted && Neo.main.DomAccess.scrollToTableRow({id, windowId: me.windowId})`
`137`	`137`	`}`
`138`	`138`	`} else {`
`139`	`139`	`selectionModel.deselectAll()`