ref: remove library update order as the app doesn't really use it now

Author: nonproto

app/build.gradle.kts

@@ -24,8 +24,8 @@ android {
         minSdk = AndroidConfig.minSdkVersion
         targetSdk = AndroidConfig.targetSdkVersion
         applicationId = "org.nekomanga.neko"
-        versionCode = 49
-        versionName = "3.1.5"
+        versionCode = 50
+        versionName = "3.1.6"
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
         multiDexEnabled = true
         setProperty("archivesBaseName", "Neko")

app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt

@@ -3,7 +3,6 @@ package eu.kanade.tachiyomi.data.library
 import android.content.Context
 import android.content.pm.ServiceInfo
 import android.os.Build
-import androidx.core.text.isDigitsOnly
 import androidx.work.Constraints
 import androidx.work.CoroutineWorker
 import androidx.work.Data
@@ -155,8 +154,6 @@ class LibraryUpdateJob(private val context: Context, workerParameters: WorkerPar
 
         instance = WeakReference(this)
 
-        val selectedScheme = libraryPreferences.updatePrioritization().get()
-
         val allLibraryManga = db.getLibraryMangaList().executeOnIO()
         val allTracks = db.getAllTracks().executeOnIO()
         val tracksByMangaId = allTracks.groupBy { it.manga_id }
@@ -183,16 +180,11 @@ class LibraryUpdateJob(private val context: Context, workerParameters: WorkerPar
                 } else {
                     allLibraryManga
                 })
-                .sortedWith(LibraryUpdateRanker.rankingScheme[selectedScheme])
 
         val categoryId = inputData.getInt(KEY_CATEGORY, -1)
 
         val mangaList =
             getAndFilterMangaToUpdate(mangaListToFilter, tracksByMangaId, categoryId)
-                .sortedWith(
-                    LibraryUpdateRanker.rankingScheme[
-                            libraryPreferences.updatePrioritization().get()]
-                )
 
         return withIOContext {
             try {
@@ -801,10 +793,7 @@ class LibraryUpdateJob(private val context: Context, workerParameters: WorkerPar
             val tracksByMangaId = db.getAllTracks().executeOnIO().groupBy { it.manga_id }
             val mangaToAdd =
                 getAndFilterMangaToUpdate(manga, tracksByMangaId = tracksByMangaId, categoryId = -1)
-                    .sortedWith(
-                        LibraryUpdateRanker.rankingScheme[
-                                libraryPreferences.updatePrioritization().get()]
-                    )
+
 
             addManga(mangaToAdd)
         }
@@ -820,10 +809,6 @@ class LibraryUpdateJob(private val context: Context, workerParameters: WorkerPar
                         tracksByMangaId = tracksByMangaId,
                         categoryId = categoryId,
                     )
-                    .sortedWith(
-                        LibraryUpdateRanker.rankingScheme[
-                                libraryPreferences.updatePrioritization().get()]
-                    )
             addManga(mangaToAdd)
         }
     }
@@ -840,15 +825,7 @@ class LibraryUpdateJob(private val context: Context, workerParameters: WorkerPar
                 distinctManga.map { manga ->
                     async(Dispatchers.IO) {
                         val shouldDownload = manga.shouldDownloadNewChapters(db, preferences)
-                        val hasDLs =
-                            if (MdUtil.getMangaUUID(manga.url).isDigitsOnly()) {
-                                TimberKt.w {
-                                    "Manga : ${manga.title} is not migrated to v5 skipping"
-                                }
-                                false
-                            } else {
-                                updateMangaChapters(manga, shouldDownload)
-                            }
+                        val hasDLs = updateMangaChapters(manga, shouldDownload)
 
                         if (hasDLs && !hasDownloads) {
                             hasDownloads = true

app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateRanker.kt

@@ -58,8 +58,6 @@ class LibraryPreferences(private val preferenceStore: PreferenceStore) {
     fun whichCategoriesToExclude() =
         this.preferenceStore.getStringSet("library_update_categories_exclude")
 
-    fun updatePrioritization() = this.preferenceStore.getInt("library_update_prioritization")
-
     fun layout() =
         this.preferenceStore.getObjectFromInt(
             key = "pref_display_library_layout",
@@ -114,8 +112,6 @@ class LibraryPreferences(private val preferenceStore: PreferenceStore) {
             deserializer = LibraryGroup::fromInt,
         )
 
-    fun showCategoryInTitle() = this.preferenceStore.getBoolean("category_in_title")
-
     fun updateFaster() = this.preferenceStore.getBoolean("faster_library_updates")
 
     fun updateCovers() = this.preferenceStore.getBoolean("refresh_covers_too", true)

app/src/main/java/org/nekomanga/domain/library/LibraryPreferences.kt

@@ -245,16 +245,6 @@ internal class LibrarySettingsScreen(
                         pref = libraryPreferences.updateFaster(),
                         title = stringResource(R.string.faster_library_update),
                     ),
-                    Preference.PreferenceItem.ListPreference(
-                        pref = libraryPreferences.updatePrioritization(),
-                        title = stringResource(R.string.library_update_order),
-                        entries =
-                            persistentMapOf(
-                                0 to stringResource(R.string.alphabetically),
-                                1 to stringResource(R.string.last_updated),
-                                2 to stringResource(R.string.next_updated),
-                            ),
-                    ),
                     Preference.PreferenceItem.TextPreference(
                         title = stringResource(R.string.categories),
                         subtitle =
@@ -320,10 +310,6 @@ internal class LibrarySettingsScreen(
                     title = stringResource(R.string.faster_library_update),
                     group = stringResource(R.string.global_updates),
                 ),
-                SearchTerm(
-                    title = stringResource(R.string.library_update_order),
-                    group = stringResource(R.string.global_updates),
-                ),
                 SearchTerm(
                     title = stringResource(R.string.categories),
                     group = stringResource(R.string.global_updates),

app/src/main/java/org/nekomanga/presentation/screens/settings/screens/LibrarySettingsScreen.kt

@@ -307,7 +307,6 @@
 
     <!-- Library settings -->
     <string name="library_update_frequency">Library update frequency</string>
-    <string name="library_update_order">Library update order</string>
     <string name="library_update_device_restriction">Library device auto update restrictions</string>
     <string name="library_update__device_restriction_summary">Update only when the conditions are met</string>
     <string name="restrictions_">Restrictions: %1$s</string>