Skip to content

--days off by one day when using --no-ari #103

@gkloepfer

Description

@gkloepfer

The comparison of the number of days remaining before reissuing certificates is off by one day, per the definition in the man page:

      -d, --days DAYS
       Do not reissue certificates that are still valid for
       longer than DAYS (default 30). This only applies as
       a fallback if no server renewal information is available.
       See also -i, --no-ari and -o, --no-ocsp.

The comparison in crypto.c will not renew certificates until they are still valid for DAYS - 1 in the comparisons of "validity" in crypto.c when using --no-ari.

The patch provided (against tag 1.7.6) changes the comparison so that the behavior is consistent with the description in the manual page.

1.7.6-days-less-than-or-equal.patch

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions