update GoSS format and Packer on_error validations

Author: mschuchard

CHANGELOG.md

@@ -1,6 +1,7 @@
 ### 1.3.2 (Next)
 - Miscellaneous minor Terraform module plugin fixes.
 - Minor documentation corrections.
+- Update GoSS `format` and Packer `on_error` validations.
 
 ### 1.3.1
 - Improve accuracy of `default` in plugin documentation.

plugins/module_utils/goss.py

@@ -68,7 +68,6 @@ def cmd(action: str, flags: set[str] = set(), args: dict[str, str | int | dict]
             elif arg == 'format' and arg_value not in [
                 'documentation',
                 'json',
-                'json_oneline',
                 'junit',
                 'nagios',
                 'prometheus',

plugins/module_utils/packer.py

@@ -65,6 +65,10 @@ def cmd(action: str, flags: set[str] = set(), args: dict[str, str | int | list[s
             # note for next two conditionals second logical tests for whether str or list is expected based on pseudo-schema in ARGS_MAP
             # if the arg value is a str, then append the value interpolated with the arg name from the dict to the command
             if (isinstance(arg_value, str) or isinstance(arg_value, bool)) and len(action_args_map[arg]) > 0:
+                # validate on_error arg value
+                if arg == 'on_error' and arg_value not in ['cleanup', 'abort', 'ask', 'run-cleanup-provisioner']:
+                    raise RuntimeError(f'Unsupported on error argument value specified: {arg_value}')
+
                 command.append(f'{action_args_map[arg]}{arg_value}')
             # if the arg value is a list, then extend the command with the values because they are already formatted correctly
             elif isinstance(arg_value, list) and len(action_args_map[arg]) == 0: