fixes from improved pylance analysis

Author: mschuchard

plugins/modules/goss_render.py

@@ -104,9 +104,9 @@ def main() -> None:
         cwd = gossfile.parent
 
     # check on optional debug param
-    flags: list[str] = []
+    flags: set[str] = set()
     if module.params.get('debug'):
-        flags.append('debug')
+        flags.add('debug')
 
     # check args
     args: dict = {}

plugins/modules/packer_build.py

@@ -156,13 +156,13 @@ def main() -> None:
     var_file: list[Path] = module.params.get('var_file')
 
     # check optional params
-    flags: list[str] = []
+    flags: set[str] = set()
     if module.params.get('debug'):
-        flags.append('debug')
+        flags.add('debug')
     if module.params.get('force'):
-        flags.append('force')
+        flags.add('force')
     if module.params.get('timestamp_ui'):
-        flags.append('timestamp_ui')
+        flags.add('timestamp_ui')
 
     args: dict = {}
     if excepts:

plugins/modules/packer_fmt.py

@@ -103,14 +103,14 @@ def main() -> None:
     config_dir: Path = Path(module.params.get('config_dir'))
 
     # check flags
-    flags: list[str] = []
+    flags: set[str] = set()
     if check:
-        flags.append('check')
+        flags.add('check')
         changed = False
     if module.params.get('diff'):
-        flags.append('diff')
+        flags.add('diff')
     if module.params.get('recursive'):
-        flags.append('recursive')
+        flags.add('recursive')
 
     # check args
     args: dict = {}

plugins/modules/packer_init.py

@@ -79,9 +79,9 @@ def main() -> None:
     config_dir: Path = Path(module.params.get('config_dir'))
 
     # check on optional upgrade param
-    flags: list[str] = []
+    flags: set[str] = set()
     if module.params.get('upgrade'):
-        flags.append('upgrade')
+        flags.add('upgrade')
 
     # determine packer command
     command: list[str] = packer.cmd(action='init', flags=flags, target_dir=config_dir)

plugins/modules/packer_validate.py

@@ -137,13 +137,13 @@ def main() -> None:
     var_file: list[Path] = module.params.get('var_file')
 
     # check flags
-    flags: list[str] = []
+    flags: set[str] = set()
     if module.params.get('evaluate_datasources'):
-        flags.append('evaluate_datasources')
+        flags.add('evaluate_datasources')
     if module.params.get('syntax_only'):
-        flags.append('syntax_only')
+        flags.add('syntax_only')
     if not module.params.get('warn_undeclared_var'):
-        flags.append('no_warn_undeclared_var')
+        flags.add('no_warn_undeclared_var')
 
     # check args
     args: dict = {}

plugins/modules/puppet_agent.py

@@ -133,19 +133,19 @@ def main() -> None:
         args.update({'server_port': server_port})
 
     # check on optional flag params
-    flags: list[str] = []
+    flags: set[str] = set()
     if module.params.get('debug'):
-        flags.append('debug')
+        flags.add('debug')
     if module.params.get('no_daemonize'):
-        flags.append('no_daemonize')
+        flags.add('no_daemonize')
     if module.params.get('no_op'):
-        flags.append('no_op')
+        flags.add('no_op')
     if module.params.get('onetime'):
-        flags.append('onetime')
+        flags.add('onetime')
     if test:
-        flags.append('test')
+        flags.add('test')
     if module.params.get('verbose'):
-        flags.append('verbose')
+        flags.add('verbose')
 
     # determine puppet command
     command: list[str] = puppet.cmd(action='agent', flags=flags, args=args)

plugins/modules/puppet_apply.py

@@ -101,15 +101,15 @@ def main() -> None:
     test: bool = module.params.get('test')
 
     # check on optional flag params
-    flags: list[str] = []
+    flags: set[str] = set()
     if module.params.get('debug'):
-        flags.append('debug')
+        flags.add('debug')
     if module.params.get('no_op'):
-        flags.append('no_op')
+        flags.add('no_op')
     if test:
-        flags.append('test')
+        flags.add('test')
     if module.params.get('verbose'):
-        flags.append('verbose')
+        flags.add('verbose')
 
     # determine puppet command
     command: list[str] = puppet.cmd(action='apply', flags=flags, manifest=manifest)

plugins/modules/terraform_apply.py

@@ -128,9 +128,9 @@ def main() -> None:
     # else check flags and other args
     else:
         # check flags
-        flags: list[str] = []
+        flags: set[str] = set()
         if module.params.get('destroy'):
-            flags.append('destroy')
+            flags.add('destroy')
 
         # check args
         args: dict = {}

plugins/modules/terraform_fmt.py

@@ -99,14 +99,14 @@ def main() -> None:
     changed: bool = True
 
     # check flags
-    flags: list[str] = []
+    flags: set[str] = set()
     if module.params.get('check'):
-        flags.append('check')
+        flags.add('check')
         changed = False
     if module.params.get('diff'):
-        flags.append('diff')
+        flags.add('diff')
     if module.params.get('recursive'):
-        flags.append('recursive')
+        flags.add('recursive')
 
     # check args
     args: dict = {}

plugins/modules/terraform_import.py

@@ -95,6 +95,7 @@ def main() -> None:
     )
 
     # initialize
+    changed: bool = False
     config_dir: Path = Path(module.params.get('config_dir'))
     address: str = module.params.get('address')
     id: str = module.params.get('id')
@@ -118,7 +119,7 @@ def main() -> None:
 
     # exit early for check mode
     if module.check_mode:
-        module.exit_json(changed=False, command=command)
+        module.exit_json(changed=changed, command=command)
 
     # execute terraform
     return_code: int