modified initialization of members

Author: marazmista

radeon-profile/daemonComm.cpp

@@ -4,8 +4,7 @@
 #include "daemonComm.h"
 #include <QDebug>
 
-daemonComm::daemonComm() {
-    signalSender = new QLocalSocket(this);
+daemonComm::daemonComm() : signalSender(new QLocalSocket(this)) {
     feedback.setDevice(signalSender);
     connect(signalSender,SIGNAL(readyRead()), this, SLOT(receiveFeedback()));
 }

radeon-profile/dxorg.cpp

@@ -11,7 +11,7 @@
 #include <QString>
 #include <QStringList>
 
-dXorg::dXorg(const GPUSysInfo &si) {
+dXorg::dXorg(const GPUSysInfo &si) : ioctlHnd(nullptr) {
     features.sysInfo = si;
     configure();
     figureOutConstParams();

radeon-profile/dxorg.h

@@ -25,7 +25,7 @@ class dXorg
     };
 
 public:
-    dXorg() { }
+    dXorg() : ioctlHnd(nullptr) { }
     dXorg(const GPUSysInfo &si);
 
     void cleanup() {
@@ -79,7 +79,7 @@ class dXorg
     RxPatterns rxPatterns;
 
     daemonComm dcomm;
-    ioctlHandler *ioctlHnd = nullptr;
+    ioctlHandler *ioctlHnd;
 
     QString getClocksRawData(bool forFeatures = false);
     QString findSysfsHwmonForGPU();

radeon-profile/execbin.cpp

@@ -7,16 +7,17 @@
 #include <QLabel>
 #include <QFileDialog>
 
-ExecBin::ExecBin() : QObject() {
-    p = new QProcess();
-    mainLay = new QVBoxLayout();
-    btnLay = new QHBoxLayout();
-    tab = new QWidget();
-    output = new QPlainTextEdit();
-    cmd = new QPlainTextEdit();
-    lStatus = new QLabel();
-    btnSave = new QPushButton();
-
+ExecBin::ExecBin() : QObject(),
+    tab(new QWidget()),
+    p(new QProcess(this)),
+    output(new QPlainTextEdit()),
+    cmd(new QPlainTextEdit()),
+    mainLay(new  QVBoxLayout()),
+    btnLay(new QHBoxLayout()),
+    lStatus(new QLabel()),
+    btnSave(new QPushButton())
+
+{
     setupTab();
 
     connect(p,SIGNAL(readyReadStandardOutput()),this,SLOT(execProcessReadOutput()));

radeon-profile/gpu.h

@@ -16,8 +16,7 @@ class gpu : public QObject
 
     Q_OBJECT
 public:
-    explicit gpu(QObject *parent = 0 ) : QObject(parent) {
-        currentGpuIndex = 0;
+    explicit gpu(QObject *parent = 0 ) : QObject(parent), currentGpuIndex(0) {
         connect(&futureGpuUsage, SIGNAL(finished()),this,SLOT(handleGpuUsageResult()));
     }
 

radeon-profile/radeon_profile.cpp

@@ -33,6 +33,12 @@ unsigned int radeon_profile::minFanStepsSpeed = 10;
 
 radeon_profile::radeon_profile(QWidget *parent) :
     QMainWindow(parent),
+    timer(new QTimer(this)),
+    counter_ticks(0),
+    counter_statsTick(0),
+    hysteresisRelativeTepmerature(0),
+    ocTableModified(false),
+    savedState(nullptr),
     ui(new Ui::radeon_profile)
 {
     ui->setupUi(this);
@@ -46,7 +52,6 @@ radeon_profile::radeon_profile(QWidget *parent) :
         ui->label_rootWarrning->setVisible(false);
     }
 
-    timer = new QTimer(this);
     loadConfig();
 
     // find device and initialize it
@@ -59,10 +64,6 @@ radeon_profile::radeon_profile(QWidget *parent) :
         return;
     }
 
-    counter_ticks = 0;
-    counter_statsTick = 0;
-    savedState = nullptr;
-
     // create runtime stuff, setup rest of ui
     setupUiElements();
 

radeon-profile/radeon_profile.h

@@ -161,7 +161,7 @@ private slots:
 
     QSystemTrayIcon *icon_tray;
     QAction *refreshWhenHidden;
-    QTimer *timer = nullptr;
+    QTimer *timer;
 
     gpu device;
     QList<ExecBin*> execsRunning;
@@ -170,8 +170,8 @@ private slots:
     QMap<QString, RPEvent> events;
     QMap<QString, unsigned int> pmStats;
     unsigned int counter_ticks, counter_statsTick;
-    short hysteresisRelativeTepmerature = 0;
-    bool ocTableModified = false;
+    short hysteresisRelativeTepmerature;
+    bool ocTableModified;
     QButtonGroup group_pwm, group_Dpm;
     CurrentStateInfo *savedState;
     PlotManager plotManager;