Removing sonar issues

Lorenzo Solano Martinez · Lorenzo Solano Martinez · commit e0b2389f0273 · 2025-06-05T21:39:28.000-04:00
diff --git a/src/Validations/ArgumentsHelpers/OutOfRangeChecks.cs b/src/Validations/ArgumentsHelpers/OutOfRangeChecks.cs
@@ -8,7 +8,7 @@ internal static TComparable LessThan<TComparable>([NotNull] TComparable? value,
         where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxExclusiveOnly(
-                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
         return CheckBoundaries(value, range, paramName, null);
     }
 
@@ -18,9 +18,9 @@ internal static TComparable LessThan<TComparable>([NotNull] TComparable? value,
         [NotNull] string customMessage) where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxExclusiveOnly(
-                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
 
-        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));
+        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());
     }
 
     [return: NotNull]
@@ -29,7 +29,7 @@ internal static TComparable LessThanOrEqualTo<TComparable>([NotNull] TComparable
         where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxInclusiveOnly(
-                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
 
         return CheckBoundaries(value, range, paramName, null);
     }
@@ -41,9 +41,9 @@ internal static TComparable LessThanOrEqualTo<TComparable>([NotNull] TComparable
         where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxInclusiveOnly(
-                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
 
-        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));
+        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());
     }
 
     [return: NotNull]
@@ -52,7 +52,7 @@ internal static TComparable GreaterThan<TComparable>([NotNull] TComparable? valu
         where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMinExclusiveOnly(
-                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+                SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
 
         return CheckBoundaries(value, range, paramName, null);
     }
@@ -63,9 +63,9 @@ internal static TComparable GreaterThan<TComparable>([NotNull] TComparable? valu
         [NotNull] string customMessage) where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMinExclusiveOnly(
-            SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+            SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
 
-        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));
+        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());
     }
 
     [return: NotNull]
@@ -74,7 +74,7 @@ internal static TComparable GreaterThanOrEqualTo<TComparable>([NotNull] TCompara
         where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMinInclusiveOnly(
-            SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+            SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
 
         return CheckBoundaries(value, range, paramName, null);
     }
@@ -85,9 +85,9 @@ internal static TComparable GreaterThanOrEqualTo<TComparable>([NotNull] TCompara
         [NotNull] string customMessage) where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = ComparableRangeFactory.WithMinInclusiveOnly(
-            SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));
+            SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));
 
-        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));
+        return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());
     }
 
     [return: NotNull]
@@ -119,13 +119,13 @@ internal static TComparable Between<TComparable>(
         [NotNull] string customMessage) where TComparable : IComparable<TComparable>
     {
         ComparableRange<TComparable> range = new(
-            SimpleOption.SomeNotNull(fromInclusive.ValueOrThrowIfNull(nameof(fromInclusive))),
-            SimpleOption.SomeNotNull(toInclusive.ValueOrThrowIfNull(nameof(toInclusive))));
+            SimpleOption.SomeNotNull(fromInclusive.ValueOrThrowIfNull()),
+            SimpleOption.SomeNotNull(toInclusive.ValueOrThrowIfNull()));
 
         return range.Contains(
-                    value.ValueOrThrowIfNull(nameof(value)),
-                    paramName.ValueOrThrowIfNull(nameof(customMessage)),
-                    customMessage.ValueOrThrowIfNull(nameof(customMessage)));
+                    value.ValueOrThrowIfNull(),
+                    paramName.ValueOrThrowIfNull(),
+                    customMessage.ValueOrThrowIfNull());
 
     }
 
@@ -136,7 +136,7 @@ private static TComparable CheckBoundaries<TComparable>(
         [NotNull] string paramName,
         string? customMessage) where TComparable : IComparable<TComparable>
             => range.Contains(
-                value.ValueOrThrowIfNull(nameof(value)),
-                paramName.ValueOrThrowIfNull(nameof(paramName)),
+                value.ValueOrThrowIfNull(),
+                paramName.ValueOrThrowIfNull(),
                 customMessage);
 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ internal static TComparable LessThan<TComparable>([NotNull] TComparable? value,`
`8`	`8`	`where TComparable : IComparable<TComparable>`
`9`	`9`	`{`
`10`	`10`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxExclusiveOnly(`
`11`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`11`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`12`	`12`	`return CheckBoundaries(value, range, paramName, null);`
`13`	`13`	`}`
`14`	`14`
`@@ -18,9 +18,9 @@ internal static TComparable LessThan<TComparable>([NotNull] TComparable? value,`
`18`	`18`	`[NotNull] string customMessage) where TComparable : IComparable<TComparable>`
`19`	`19`	`{`
`20`	`20`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxExclusiveOnly(`
`21`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`21`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`22`	`22`
`23`		`- return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));`
	`23`	`+ return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`[return: NotNull]`
`@@ -29,7 +29,7 @@ internal static TComparable LessThanOrEqualTo<TComparable>([NotNull] TComparable`
`29`	`29`	`where TComparable : IComparable<TComparable>`
`30`	`30`	`{`
`31`	`31`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxInclusiveOnly(`
`32`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`32`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`33`	`33`
`34`	`34`	`return CheckBoundaries(value, range, paramName, null);`
`35`	`35`	`}`
`@@ -41,9 +41,9 @@ internal static TComparable LessThanOrEqualTo<TComparable>([NotNull] TComparable`
`41`	`41`	`where TComparable : IComparable<TComparable>`
`42`	`42`	`{`
`43`	`43`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMaxInclusiveOnly(`
`44`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`44`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`45`	`45`
`46`		`- return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));`
	`46`	`+ return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`[return: NotNull]`
`@@ -52,7 +52,7 @@ internal static TComparable GreaterThan<TComparable>([NotNull] TComparable? valu`
`52`	`52`	`where TComparable : IComparable<TComparable>`
`53`	`53`	`{`
`54`	`54`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMinExclusiveOnly(`
`55`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`55`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`56`	`56`
`57`	`57`	`return CheckBoundaries(value, range, paramName, null);`
`58`	`58`	`}`
`@@ -63,9 +63,9 @@ internal static TComparable GreaterThan<TComparable>([NotNull] TComparable? valu`
`63`	`63`	`[NotNull] string customMessage) where TComparable : IComparable<TComparable>`
`64`	`64`	`{`
`65`	`65`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMinExclusiveOnly(`
`66`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`66`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`67`	`67`
`68`		`- return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));`
	`68`	`+ return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`[return: NotNull]`
`@@ -74,7 +74,7 @@ internal static TComparable GreaterThanOrEqualTo<TComparable>([NotNull] TCompara`
`74`	`74`	`where TComparable : IComparable<TComparable>`
`75`	`75`	`{`
`76`	`76`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMinInclusiveOnly(`
`77`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`77`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`78`	`78`
`79`	`79`	`return CheckBoundaries(value, range, paramName, null);`
`80`	`80`	`}`
`@@ -85,9 +85,9 @@ internal static TComparable GreaterThanOrEqualTo<TComparable>([NotNull] TCompara`
`85`	`85`	`[NotNull] string customMessage) where TComparable : IComparable<TComparable>`
`86`	`86`	`{`
`87`	`87`	`ComparableRange<TComparable> range = ComparableRangeFactory.WithMinInclusiveOnly(`
`88`		`- SimpleOption.SomeNotNull(other.ValueOrThrowIfNull(nameof(other))));`
	`88`	`+ SimpleOption.SomeNotNull(other.ValueOrThrowIfNull()));`
`89`	`89`
`90`		`- return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull(nameof(customMessage)));`
	`90`	`+ return CheckBoundaries(value, range, paramName, customMessage.ValueOrThrowIfNull());`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`[return: NotNull]`
`@@ -119,13 +119,13 @@ internal static TComparable Between<TComparable>(`
`119`	`119`	`[NotNull] string customMessage) where TComparable : IComparable<TComparable>`
`120`	`120`	`{`
`121`	`121`	`ComparableRange<TComparable> range = new(`
`122`		`- SimpleOption.SomeNotNull(fromInclusive.ValueOrThrowIfNull(nameof(fromInclusive))),`
`123`		`- SimpleOption.SomeNotNull(toInclusive.ValueOrThrowIfNull(nameof(toInclusive))));`
	`122`	`+ SimpleOption.SomeNotNull(fromInclusive.ValueOrThrowIfNull()),`
	`123`	`+ SimpleOption.SomeNotNull(toInclusive.ValueOrThrowIfNull()));`
`124`	`124`
`125`	`125`	`return range.Contains(`
`126`		`- value.ValueOrThrowIfNull(nameof(value)),`
`127`		`- paramName.ValueOrThrowIfNull(nameof(customMessage)),`
`128`		`- customMessage.ValueOrThrowIfNull(nameof(customMessage)));`
	`126`	`+ value.ValueOrThrowIfNull(),`
	`127`	`+ paramName.ValueOrThrowIfNull(),`
	`128`	`+ customMessage.ValueOrThrowIfNull());`
`129`	`129`
`130`	`130`	`}`
`131`	`131`
`@@ -136,7 +136,7 @@ private static TComparable CheckBoundaries<TComparable>(`
`136`	`136`	`[NotNull] string paramName,`
`137`	`137`	`string? customMessage) where TComparable : IComparable<TComparable>`
`138`	`138`	`=> range.Contains(`
`139`		`- value.ValueOrThrowIfNull(nameof(value)),`
`140`		`- paramName.ValueOrThrowIfNull(nameof(paramName)),`
	`139`	`+ value.ValueOrThrowIfNull(),`
	`140`	`+ paramName.ValueOrThrowIfNull(),`
`141`	`141`	`customMessage);`
`142`	`142`	`}`