Skip to content

Commit 63efe5f

Browse files
Lorenzo Solano MartinezLorenzo Solano Martinez
Lorenzo Solano Martinez
authored and
Lorenzo Solano Martinez
committed
PR comments
1 parent 0c7d291 commit 63efe5f

File tree

4 files changed

+0
-311
lines changed

4 files changed

+0
-311
lines changed

‎src/Validations/Arguments.cs‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ public static string NotEmptyNorWhiteSpaceOnlyOrException(
8888
/// </exception>
8989
[DebuggerStepThrough]
9090
[return: NotNull]
91-
//TODO: Refactor tests for NotEmptyNorWhiteSpaceOnlyOrExceptionWithMessage
9291
public static string NotEmptyNorWhiteSpaceOnlyOrExceptionWithMessage(
9392
[NotNull] string? value,
9493
[NotNull] string customMessage,
@@ -108,7 +107,6 @@ public static string NotEmptyNorWhiteSpaceOnlyOrExceptionWithMessage(
108107
/// </exception>
109108
[DebuggerStepThrough]
110109
[return: NotNull]
111-
//TODO: Refactor tests for NotEmptyOrException
112110
public static string NotEmptyOrException(
113111
[NotNull] string? value,
114112
[NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
@@ -122,7 +120,6 @@ public static string NotEmptyOrException(
122120
/// <returns><paramref name="value"/></returns>
123121
/// <exception cref="ArgumentException">If <paramref name="value"/> is an empty <see cref="Guid"/>.</exception>
124122
[DebuggerStepThrough]
125-
//TODO: Refactor tests for NotEmptyOrException
126123
public static Guid NotEmptyOrException(Guid value,
127124
[NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
128125
{
@@ -142,7 +139,6 @@ public static Guid NotEmptyOrException(Guid value,
142139
/// <exception cref="ArgumentOutOfRangeException">If <paramref name="value"/> length is zero.</exception>
143140
[DebuggerStepThrough]
144141
[return: NotNull]
145-
//TODO: Refactor tests for NotEmptyOrExceptionWithMessage
146142
public static string NotEmptyOrExceptionWithMessage(
147143
[NotNull] string? value,
148144
[NotNull] string customMessage,
@@ -167,7 +163,6 @@ public static string NotEmptyOrExceptionWithMessage(
167163
/// <returns><paramref name="value"/></returns>
168164
/// <exception cref="ArgumentException">If <paramref name="value"/> is an empty <see cref="Guid"/>.</exception>
169165
[DebuggerStepThrough]
170-
//TODO: Refactor tests for NotEmptyOrExceptionWithMessage
171166
public static Guid NotEmptyOrExceptionWithMessage(Guid value,
172167
[NotNull] string customMessage,
173168
[NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
@@ -199,7 +194,6 @@ public static Guid NotEmptyOrExceptionWithMessage(Guid value,
199194
/// </exception>
200195
[DebuggerStepThrough]
201196
[return: NotNull]
202-
//TODO: Refactor tests for MemberOfOrException
203197
public static TEnumType MemberOfOrException<TEnumType>(TEnumType value,
204198
[NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
205199
where TEnumType : Enum
@@ -218,7 +212,6 @@ public static TEnumType MemberOfOrException<TEnumType>(TEnumType value,
218212
/// </exception>
219213
[DebuggerStepThrough]
220214
[return: NotNull]
221-
//TODO: Refactor tests for MemberOfOrExceptionWithMessage
222215
public static TEnumType MemberOfOrExceptionWithMessage<TEnumType>(TEnumType value,
223216
string customMessage,
224217
[NotNull, CallerArgumentExpression(nameof(value))] string paramName = "") where TEnumType : Enum
@@ -243,7 +236,6 @@ public static TEnumType MemberOfOrExceptionWithMessage<TEnumType>(TEnumType valu
243236
/// </exception>
244237
[DebuggerStepThrough]
245238
[return: NotNull]
246-
//TODO: Refactor tests for LessThanOrException
247239
public static TComparable LessThanOrException<TComparable>(
248240
[NotNull] TComparable? value,
249241
[NotNull] TComparable other,
@@ -266,7 +258,6 @@ public static TComparable LessThanOrException<TComparable>(
266258
/// </exception>
267259
[DebuggerStepThrough]
268260
[return: NotNull]
269-
//TODO: Refactor tests for LessThanOrExceptionWithMessage
270261
public static TComparable LessThanOrExceptionWithMessage<TComparable>(
271262
[NotNull] TComparable? value,
272263
[NotNull] TComparable other,
@@ -290,7 +281,6 @@ public static TComparable LessThanOrExceptionWithMessage<TComparable>(
290281
/// </exception>
291282
[DebuggerStepThrough]
292283
[return: NotNull]
293-
//TODO: Refactor tests for LessThanOrEqualToOrException
294284
public static TComparable LessThanOrEqualToOrException<TComparable>(
295285
[NotNull] TComparable? value,
296286
[NotNull] TComparable other,
@@ -313,7 +303,6 @@ public static TComparable LessThanOrEqualToOrException<TComparable>(
313303
/// </exception>
314304
[DebuggerStepThrough]
315305
[return: NotNull]
316-
//TODO: Refactor tests for LessThanOrEqualToOrExceptionWithMessage
317306
public static TComparable LessThanOrEqualToOrExceptionWithMessage<TComparable>(
318307
[NotNull] TComparable? value,
319308
[NotNull] TComparable other,
@@ -336,7 +325,6 @@ public static TComparable LessThanOrEqualToOrExceptionWithMessage<TComparable>(
336325
/// </exception>
337326
[DebuggerStepThrough]
338327
[return: NotNull]
339-
//TODO: Refactor tests for GreaterThanOrException
340328
public static TComparable GreaterThanOrException<TComparable>(
341329
[NotNull] TComparable? value,
342330
[NotNull] TComparable other,
@@ -359,7 +347,6 @@ public static TComparable GreaterThanOrException<TComparable>(
359347
/// </exception>
360348
[DebuggerStepThrough]
361349
[return: NotNull]
362-
//TODO: Refactor tests for GreaterThanOrExceptionWithMessage
363350
public static TComparable GreaterThanOrExceptionWithMessage<TComparable>(
364351
[NotNull] TComparable? value,
365352
[NotNull] TComparable other,
@@ -383,7 +370,6 @@ public static TComparable GreaterThanOrExceptionWithMessage<TComparable>(
383370
/// </exception>
384371
[DebuggerStepThrough]
385372
[return: NotNull]
386-
//TODO: Refactor tests for GreaterThanOrEqualToOrException
387373
public static TComparable GreaterThanOrEqualToOrException<TComparable>(
388374
[NotNull] TComparable? value,
389375
[NotNull] TComparable other,
@@ -408,7 +394,6 @@ public static TComparable GreaterThanOrEqualToOrException<TComparable>(
408394
/// </exception>
409395
[DebuggerStepThrough]
410396
[return: NotNull]
411-
//TODO: Refactor tests for GreaterThanOrEqualToOrExceptionWithMessage
412397
public static TComparable GreaterThanOrEqualToOrExceptionWithMessage<TComparable>(
413398
[NotNull] TComparable? value,
414399
[NotNull] TComparable other,
@@ -460,7 +445,6 @@ public static TComparable BetweenOrException<TComparable>(
460445
/// </exception>
461446
[DebuggerStepThrough]
462447
[return: NotNull]
463-
//TODO: Refactor tests for BetweenOrExceptionWithMessage
464448
public static TComparable BetweenOrExceptionWithMessage<TComparable>(
465449
[NotNull] TComparable? value,
466450
[NotNull] TComparable fromInclusive,
@@ -492,7 +476,6 @@ public static TComparable BetweenOrExceptionWithMessage<TComparable>(
492476
/// </exception>
493477
[DebuggerStepThrough]
494478
[return: NotNull]
495-
//TODO: Refactor tests for ValidLuhnChecksum
496479
public static string ValidLuhnChecksum([NotNull] string? value, [NotNull] string customMessage,
497480
[NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
498481
{
@@ -536,7 +519,6 @@ private static int[] ToDigitsArray(string notNullValue)
536519
/// <exception cref="ArgumentNullException">When any parameter is <see langword="null"/></exception>
537520
/// <exception cref="FormatException">If <paramref name="value"/> is not a valid Base64 String.</exception>
538521
[DebuggerStepThrough]
539-
//TODO: Refactor tests for ValidBase64
540522
public static string ValidBase64([NotNull] string? value, [NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
541523
{
542524
string validParamName =
@@ -558,7 +540,6 @@ public static string ValidBase64([NotNull] string? value, [NotNull, CallerArgume
558540
/// <exception cref="ArgumentNullException">When any parameter is <see langword="null"/></exception>
559541
/// <exception cref="FormatException">If <paramref name="value"/> is not a valid Base64 String.</exception>
560542
[DebuggerStepThrough]
561-
//TODO: Refactor tests for ValidBase64
562543
public static string ValidBase64([NotNull] string? value, [NotNull] string customMessage,
563544
[NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
564545
{
@@ -592,7 +573,6 @@ private static bool IsBase64String(string base64)
592573
/// <param name="preconditionDescription">Description for the custom precondition.</param>
593574
/// <typeparam name="TNullable"></typeparam>
594575
[DebuggerStepThrough]
595-
//TODO: Refactor tests for CompliesWith
596576
public static TNullable CompliesWith<TNullable>(
597577
[NotNull] TNullable? value,
598578
[NotNull] Func<TNullable, bool> validator,
@@ -611,7 +591,6 @@ public static TNullable CompliesWith<TNullable>(
611591
/// <param name="preconditionDescription">Description for the custom precondition.</param>
612592
/// <typeparam name="TNullable"></typeparam>
613593
[DebuggerStepThrough]
614-
//TODO: Refactor tests for DoesNotComplyWith
615594
public static TNullable DoesNotComplyWith<TNullable>(
616595
[NotNull] TNullable? value,
617596
[NotNull] Func<TNullable, bool> validator,

‎tests/unit/Validations.Tests/ArgumentsFacts/CompliesWithMessageFacts.cs‎

Lines changed: 0 additions & 46 deletions
This file was deleted.

‎tests/unit/Validations.Tests/ArgumentsFacts/NotNullEmptyOrWhiteSpaceOnly_Facts.cs‎

Lines changed: 0 additions & 118 deletions
This file was deleted.

0 commit comments

Comments
 (0)