Closes #31: Remove Sonar issues

Author: Lorenzo Solano Martinez

src/Validations/Arguments.cs

@@ -176,7 +176,7 @@ public static Guid NotEmptyOrExceptionWithMessage(Guid value,
             : value;
     }
 
-    private static bool IsEmpty(Guid value) => value == default;
+    private static bool IsEmpty(Guid value) => value == Guid.Empty;
 
     #endregion
 
@@ -579,7 +579,7 @@ public static TNullable CompliesWith<TNullable>(
         [NotNull] string preconditionDescription,
         [NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
             where TNullable : class
-            => CompliesWithExpected(value, validator, paramName, preconditionDescription, true);
+            => CompliesWithExpected(value, validator, preconditionDescription, paramName, true);
 
     /// <summary>
     /// Checks the given value for <see langword="null"/> and then if the its complies with the validator function. 
@@ -597,7 +597,7 @@ public static TNullable DoesNotComplyWith<TNullable>(
         [NotNull] string preconditionDescription,
         [NotNull, CallerArgumentExpression(nameof(value))] string paramName = "")
             where TNullable : class
-            => CompliesWithExpected(value, validator, paramName, preconditionDescription, false);
+            => CompliesWithExpected(value, validator, preconditionDescription, paramName, false);
 
     [return: NotNull]
     private static TNullable CompliesWithExpected<TNullable>(

src/Validations/Properties/AssemblyInfo.cs

@@ -1,13 +1,3 @@
 [assembly: CLSCompliant(true)]
 [assembly: System.Resources.NeutralResourcesLanguage("en")]
 [assembly: System.Runtime.InteropServices.ComVisible(false)]
-
-namespace Triplex.Validations.Properties;
-
-/// <summary>
-/// Assembly information.
-/// </summary>
-public sealed class AssemblyInfo
-{
-
-}

tests/unit/Validations.Tests/ArgumentsFacts/CompliesWithUsingLambdaMessageFacts.cs

@@ -27,8 +27,8 @@ public void Returns_Same_Instance()
     public void With_False_Throws_ArgumentException()
     {
         const string? someString = "Hello World 1234";
-        Assert.That(() => Arguments.CompliesWith(someString, val => val.Length > 100, nameof(someString),
-            PreconditionDescription),
+        Assert.That(() => Arguments.CompliesWith(someString, val => val.Length > 100, PreconditionDescription,
+            nameof(someString)),
             Throws.ArgumentException
                   .With.Property(nameof(ArgumentException.ParamName)).EqualTo(nameof(someString))
                   .And.Message.Contains(PreconditionDescription));
@@ -40,18 +40,18 @@ public void With_Invalid_ParamName_Throws_ArgumentException([Values(null, "", "
     {
         const string? someString = "Hello World 1235";
 
-        Assert.That(() => Arguments.CompliesWith(someString, val => precondition, paramName!, PreconditionDescription),
+        Assert.That(() => Arguments.CompliesWith(someString, val => precondition, PreconditionDescription, paramName!),
             Throws.InstanceOf<ArgumentException>()
                   .With.Property(nameof(ArgumentException.ParamName)).EqualTo("paramName"));
     }
 
     [Test]
-    public void With_Invalid_Description_ParamName_Throws_ArgumentException(
+    public void With_Invalid_Description_Throws_ArgumentException(
         [Values(null, "", " ", "\n\r\t ")] string? description, [Values] bool precondition)
     {
         const string? someString = "Hello World 1235";
 
-        Assert.That(() => Arguments.CompliesWith(someString, val => precondition, nameof(someString), description!),
+        Assert.That(() => Arguments.CompliesWith(someString, val => precondition, description!, nameof(someString)),
             Throws.InstanceOf<ArgumentException>()
                   .With.Property(nameof(ArgumentException.ParamName)).EqualTo("preconditionDescription"));
     }

tests/unit/Validations.Tests/ArgumentsFacts/DoesNotComplyWithMessageFacts.cs

@@ -27,8 +27,8 @@ public void Returns_Same_Instance()
     public void With_True_Throws_ArgumentException()
     {
         const string? someString = "123456789";
-        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => val.Length == 9, nameof(someString),
-            PreconditionDescription),
+        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => val.Length == 9, PreconditionDescription,
+        nameof(someString)),
             Throws.ArgumentException
                   .With.Property(nameof(ArgumentException.ParamName)).EqualTo(nameof(someString))
                   .And.Message.Contains(PreconditionDescription));
@@ -40,8 +40,8 @@ public void With_Invalid_ParamName_Throws_ArgumentException([Values(null, "", "
     {
         const string? someString = "Hello World 1235";
 
-        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => precondition, paramName!,
-            PreconditionDescription),
+        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => precondition,
+            PreconditionDescription, paramName!),
             Throws.InstanceOf<ArgumentException>()
                   .With.Property(nameof(ArgumentException.ParamName)).EqualTo("paramName"));
     }
@@ -52,7 +52,7 @@ public void With_Invalid_Description_ParamName_Throws_ArgumentException(
     {
         const string? someString = "Hello World 1235";
 
-        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => precondition, nameof(someString), description!),
+        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => precondition, description!, nameof(someString)),
             Throws.InstanceOf<ArgumentException>()
                   .With.Property(nameof(ArgumentException.ParamName)).EqualTo("preconditionDescription"));
     }
@@ -61,8 +61,8 @@ public void With_Invalid_Description_ParamName_Throws_ArgumentException(
     public void With_Null_Value_Throws_ArgumentNullException()
     {
         const string? someString = null;
-        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => val.Length > 100, nameof(someString),
-            PreconditionDescription),
+        Assert.That(() => Arguments.DoesNotComplyWith(someString, val => val.Length > 100,
+            PreconditionDescription, nameof(someString)),
             Throws.ArgumentNullException
                   .With.Property(nameof(ArgumentException.ParamName)).EqualTo("value")
                   .And.Message.Contains("cannot be null"));