fix: change temperature type from int to *float32

Author: nurali-techie

request/request.go

@@ -23,7 +23,7 @@ type ChatCompletionsRequest struct {
 	Stop             []string        `json:"stop,omitempty"`
 	Stream           bool            `json:"stream,omitempty"`
 	StreamOptions    *StreamOptions  `json:"stream_options,omitempty"`
-	Temperature      int             `json:"temperature,omitempty"`
+	Temperature      *float32        `json:"temperature,omitempty"`
 	TopP             *float32        `json:"top_p,omitempty"`
 	Tools            *[]Tool         `json:"tools,omitempty"`
 	ToolChoice       any             `json:"tool_choice,omitempty"`
@@ -92,3 +92,7 @@ type ToolChoiceNamed struct {
 type ToolChoiceFunction struct {
 	Name string `json:"name"`
 }
+
+func ToPtr[T any](v T) *T {
+	return &v
+}

request/request_test/validator_test.go

@@ -29,7 +29,7 @@ func TestValidateChatCompletionsRequest(t *testing.T) {
 		StreamOptions: &request.StreamOptions{
 			IncludeUsage: true,
 		},
-		Temperature: 2,
+		Temperature: request.ToPtr(float32(0.2)),
 		// TopP: nil,	// TODO: VN -- pass non nil
 	}
 	err := request.ValidateChatCompletionsRequest(req)

request/validator.go

@@ -110,13 +110,15 @@ func validateMultipleFields(req *ChatCompletionsRequest) error {
 		return fmt.Errorf("err: presence_penalty is invalid; it should be number between -2 and 2")
 	}
 
-	if !(req.Temperature >= 0 && req.Temperature <= 2) {
-		return fmt.Errorf("err: temperature is invalid; it should be number between 0 and 2")
+	if req.Temperature != nil {
+		if !(*req.Temperature >= 0 && *req.Temperature <= 2) {
+			return fmt.Errorf("err: temperature is invalid; the valid range of temperature is [0, 2.0]")
+		}
 	}
 
 	if req.TopP != nil {
 		if !(*req.TopP > 0 && *req.TopP <= 1) {
-			return fmt.Errorf("err: invalid top_p value; the valid range of top_p is (0, 1.0]")
+			return fmt.Errorf("err: top_p is invalid; the valid range of top_p is (0, 1.0]")
 		}
 	}
 

request/validator_unit_test.go

@@ -178,3 +178,51 @@ func TestValidateStreamOptions(t *testing.T) {
 		assert.NoError(t, err)
 	})
 }
+
+func TestValidateMultipleFields(t *testing.T) {
+	t.Run("no err for valid temprature", func(t *testing.T) {
+		req := &ChatCompletionsRequest{
+			Temperature: nil,
+		}
+		err := validateMultipleFields(req)
+		assert.NoError(t, err)
+
+		req = &ChatCompletionsRequest{
+			Temperature: ToPtr(float32(0)),
+		}
+		err = validateMultipleFields(req)
+		assert.NoError(t, err)
+
+		req = &ChatCompletionsRequest{
+			Temperature: ToPtr(float32(0.1)),
+		}
+		err = validateMultipleFields(req)
+		assert.NoError(t, err)
+
+		req = &ChatCompletionsRequest{
+			Temperature: ToPtr(float32(1.9)),
+		}
+		err = validateMultipleFields(req)
+		assert.NoError(t, err)
+
+		req = &ChatCompletionsRequest{
+			Temperature: ToPtr(float32(2.0)),
+		}
+		err = validateMultipleFields(req)
+		assert.NoError(t, err)
+	})
+
+	t.Run("err for invalid temprature", func(t *testing.T) {
+		req := &ChatCompletionsRequest{
+			Temperature: ToPtr(float32(-0.1)),
+		}
+		err := validateMultipleFields(req)
+		assert.Error(t, err)
+
+		req = &ChatCompletionsRequest{
+			Temperature: ToPtr(float32(2.1)),
+		}
+		err = validateMultipleFields(req)
+		assert.Error(t, err)
+	})
+}