Skip to content

WDYT: Since we are otherwise just blindly inserting this string into the ecs.version field and it comes from an external source, is it worth performing some sort of validation here so we can fail with a useful error message if something unexpected comes back? Could be as simple as a [semver.valid](https://github.com/npm/node-semver) check. #27

@lgestc

Description

@lgestc
    WDYT: Since we are otherwise just blindly inserting this string into the `ecs.version` field and it comes from an external source, is it worth performing some sort of validation here so we can fail with a useful error message if something unexpected comes back? Could be as simple as a [`semver.valid`](https://github.com/npm/node-semver) check.

Originally posted by @lukeelmers in #20 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions