fix: update file content after sorting system alias (#24)

* fix: update file content after sorting system alias

* refactor: optimize code

* refactor: optimize code

Author: chouchouji

src/aliases.ts

@@ -86,3 +86,30 @@ export function renameAliases(
 
   reloadStoreFile(path)
 }
+
+/**
+ * Replace aliases with new aliases
+ */
+export function replaceAllAliases(path: fs.PathOrFileDescriptor, aliases: Alias[]) {
+  const content = getContentFromPath(path)
+
+  if (isEmpty(content)) {
+    return
+  }
+
+  let aliasIndex = 0
+  const data = []
+  for (const line of content.split('\n')) {
+    if (resolveAlias(line.trim()) && aliases[aliasIndex]) {
+      const { aliasName, command } = aliases[aliasIndex]
+      data.push(`alias ${aliasName}='${command}'`)
+      aliasIndex += 1
+    } else {
+      data.push(line)
+    }
+  }
+
+  fs.writeFileSync(path, data.join('\n'))
+
+  reloadStoreFile(path)
+}

src/extension.ts

@@ -3,7 +3,7 @@ import os from 'node:os'
 import path from 'node:path'
 import { isArray, isNonEmptyArray } from 'rattail'
 import * as vscode from 'vscode'
-import { appendAliasToStoreFile, deleteAliases, getAliases, renameAliases } from './aliases'
+import { appendAliasToStoreFile, deleteAliases, getAliases, renameAliases, replaceAllAliases } from './aliases'
 import { SYSTEM_ALIAS } from './constants'
 import storePath from './path'
 import type { Alias } from './types'
@@ -691,7 +691,11 @@ alias ${alias}`,
     }
 
     aliases.sort((a, b) => a.aliasName.toLowerCase().localeCompare(b.aliasName.toLowerCase()))
-    this.globalState.update(alias.group, aliases)
+    if (alias.group === SYSTEM_ALIAS) {
+      replaceAllAliases(storePath.path, aliases)
+    } else {
+      this.globalState.update(alias.group, aliases)
+    }
 
     this.refresh()
   }
@@ -704,7 +708,11 @@ alias ${alias}`,
     }
 
     aliases.sort((a, b) => (a.frequency ?? 0) - (b.frequency ?? 0))
-    this.globalState.update(alias.group, aliases)
+    if (alias.group === SYSTEM_ALIAS) {
+      replaceAllAliases(storePath.path, aliases)
+    } else {
+      this.globalState.update(alias.group, aliases)
+    }
 
     this.refresh()
   }

tests/aliases.spec.ts

@@ -3,7 +3,14 @@ import os from 'node:os'
 import path from 'node:path'
 import mockFs from 'mock-fs'
 import { afterAll, beforeAll, describe, expect, it } from 'vitest'
-import { appendAliasToStoreFile, deleteAliases, getAliases, getContentFromPath, renameAliases } from '../src/aliases'
+import {
+  appendAliasToStoreFile,
+  deleteAliases,
+  getAliases,
+  getContentFromPath,
+  renameAliases,
+  replaceAllAliases,
+} from '../src/aliases'
 
 const ZSHRC = path.join(os.homedir(), '.zshrc')
 
@@ -99,3 +106,57 @@ describe('test delete alias in .zshrc', () => {
     expect(fs.readFileSync(ZSHRC, 'utf-8')).toBe('')
   })
 })
+
+describe('test replace all aliases with new aliases', () => {
+  it('replace all aliases in .zshrc', () => {
+    fs.writeFileSync(
+      ZSHRC,
+      `# test
+test
+alias nv='node -v'
+alias pv='pnpm -v'
+# test`,
+    )
+
+    replaceAllAliases(ZSHRC, [
+      {
+        aliasName: 'nv2',
+        command: 'node -v',
+      },
+      {
+        aliasName: 'pv2',
+        command: 'pnpm -v',
+      },
+    ])
+
+    expect(fs.readFileSync(ZSHRC, 'utf-8')).toBe(`# test
+test
+alias nv2='node -v'
+alias pv2='pnpm -v'
+# test`)
+  })
+
+  it('replace some aliases in .zshrc', () => {
+    fs.writeFileSync(
+      ZSHRC,
+      `# test
+test
+alias nv='node -v'
+alias pv='pnpm -v'
+# test`,
+    )
+
+    replaceAllAliases(ZSHRC, [
+      {
+        aliasName: 'nv2',
+        command: 'node -v',
+      },
+    ])
+
+    expect(fs.readFileSync(ZSHRC, 'utf-8')).toBe(`# test
+test
+alias nv2='node -v'
+alias pv='pnpm -v'
+# test`)
+  })
+})