perf: skip to resolving clipboard when target alias is subset of source alias

Author: chouchouji

src/extension.ts

@@ -10,6 +10,7 @@ import type { Alias } from './types'
 import {
   filterAliases,
   formatUnaliasCommand,
+  isAliasSubset,
   isSameAlias,
   mergeAlias,
   normalizeAliasesToArray,
@@ -205,25 +206,27 @@ class AliasView implements vscode.TreeDataProvider<AliasItem> {
         {
           const content = await vscode.env.clipboard.readText()
           const aliases = filterAliases(content)
-          if (aliases.length) {
-            const result = mergeAlias(this.convertAliasToObject(), {
-              [SYSTEM_ALIAS]: aliases,
-            })
-            const systemAliases: Alias[] = Reflect.get(result, SYSTEM_ALIAS)
-            await this.globalState.update(SYSTEM_ALIAS, systemAliases)
-            deleteAliases(storePath.path)
-            appendAliasToStoreFile(
-              storePath.path,
-              systemAliases.map((alias) => `\nalias ${alias.aliasName}='${alias.command}'`).join(''),
-            )
-            executeCommandInTerminal(
-              systemAliases.map((alias) => `alias ${alias.aliasName}='${alias.command}'`).join('; '),
-            )
-            this.refresh()
-            vscode.window.showInformationMessage(vscode.l10n.t('Import clipboard text successfully'))
-          } else {
+
+          if (!aliases.length || isAliasSubset(Reflect.get(this.convertAliasToObject(), SYSTEM_ALIAS), aliases)) {
             vscode.window.showInformationMessage(vscode.l10n.t('No any alias need to import'))
+            return
           }
+
+          const result = mergeAlias(this.convertAliasToObject(), {
+            [SYSTEM_ALIAS]: aliases,
+          })
+          const systemAliases: Alias[] = Reflect.get(result, SYSTEM_ALIAS)
+          await this.globalState.update(SYSTEM_ALIAS, systemAliases)
+          deleteAliases(storePath.path)
+          appendAliasToStoreFile(
+            storePath.path,
+            systemAliases.map((alias) => `\nalias ${alias.aliasName}='${alias.command}'`).join(''),
+          )
+          executeCommandInTerminal(
+            systemAliases.map((alias) => `alias ${alias.aliasName}='${alias.command}'`).join('; '),
+          )
+          this.refresh()
+          vscode.window.showInformationMessage(vscode.l10n.t('Import clipboard text successfully'))
         }
         break
       case json:
@@ -255,6 +258,7 @@ class AliasView implements vscode.TreeDataProvider<AliasItem> {
 
                   return acc
                 }, {})
+
                 if (Object.values(targetAlias).length) {
                   const result = mergeAlias(this.convertAliasToObject(), targetAlias)
                   for (const [groupName, aliases] of Object.entries(result)) {

src/utils.ts

@@ -241,3 +241,19 @@ export function filterAliases(content: string) {
 
   return aliases
 }
+
+/**
+ * Check if the target is a subset of the source alias
+ * @param {Alias[]} source
+ * @param {Alias[]} target
+ * @returns {boolean}
+ */
+export function isAliasSubset(source: Alias[], target: Alias[]) {
+  const set = new Set()
+  source.forEach((alias) => {
+    const { aliasName, command } = alias
+    set.add(`${aliasName}=${command}`)
+  })
+
+  return target.every((alias) => set.has(`${alias.aliasName}=${alias.command}`))
+}

tests/utils.spec.ts

@@ -5,6 +5,7 @@ import {
   allNotEqualToTarget,
   filterAliases,
   formatUnaliasCommand,
+  isAliasSubset,
   isSameAlias,
   isValid,
   mergeAlias,
@@ -310,3 +311,48 @@ describe('test merge alias', () => {
     })
   })
 })
+
+describe('test is alias subset', () => {
+  const source: Alias[] = [
+    { aliasName: 'a', command: 'cmd1' },
+    { aliasName: 'b', command: 'cmd2' },
+    { aliasName: 'c', command: 'cmd3' },
+  ]
+
+  it('is subset', () => {
+    const target: Alias[] = [
+      { aliasName: 'a', command: 'cmd1' },
+      { aliasName: 'b', command: 'cmd2' },
+    ]
+
+    expect(isAliasSubset(source, target)).toBe(true)
+  })
+
+  it('has different aliasName', () => {
+    const target: Alias[] = [
+      { aliasName: 'c', command: 'cmd1' },
+      { aliasName: 'b', command: 'cmd3' },
+    ]
+
+    expect(isAliasSubset(source, target)).toBe(false)
+  })
+
+  it('has different command', () => {
+    const target: Alias[] = [
+      { aliasName: 'a', command: 'cmd1' },
+      { aliasName: 'b', command: 'cmd3' },
+    ]
+
+    expect(isAliasSubset(source, target)).toBe(false)
+  })
+
+  it('has another alias', () => {
+    const target: Alias[] = [
+      { aliasName: 'a', command: 'cmd1' },
+      { aliasName: 'b', command: 'cmd2' },
+      { aliasName: 'd', command: 'cmd4' },
+    ]
+
+    expect(isAliasSubset(source, target)).toBe(false)
+  })
+})