refactor: optimize code

Author: chouchouji

src/aliases.ts

@@ -100,8 +100,8 @@ export function replaceAllAliases(path: fs.PathOrFileDescriptor, aliases: Alias[
   let aliasIndex = 0
   const data = []
   for (const line of content.split('\n')) {
-    if (resolveAlias(line.trim())) {
-      const { aliasName, command } = aliases[aliasIndex] ?? {}
+    if (resolveAlias(line.trim()) && aliases[aliasIndex]) {
+      const { aliasName, command } = aliases[aliasIndex]
       data.push(`alias ${aliasName}='${command}'`)
       aliasIndex += 1
     } else {

tests/aliases.spec.ts

@@ -133,6 +133,30 @@ alias pv='pnpm -v'
 test
 alias nv2='node -v'
 alias pv2='pnpm -v'
+# test`)
+  })
+
+  it('replace some aliases in .zshrc', () => {
+    fs.writeFileSync(
+      ZSHRC,
+      `# test
+test
+alias nv='node -v'
+alias pv='pnpm -v'
+# test`,
+    )
+
+    replaceAllAliases(ZSHRC, [
+      {
+        aliasName: 'nv2',
+        command: 'node -v',
+      },
+    ])
+
+    expect(fs.readFileSync(ZSHRC, 'utf-8')).toBe(`# test
+test
+alias nv2='node -v'
+alias pv='pnpm -v'
 # test`)
   })
 })