feat: support selective deletion instead of deleting all items (#22)

* feat: support selective deletion instead of deleting all items

* test: fix test case

* refactor: optimize code

* refactor: optimize code

---------

Co-authored-by: chouchouji <[email protected]>

Author: rzzf

l10n/bundle.l10n.zh-cn.json

@@ -17,7 +17,8 @@
   "Please choose a group to add": "请选择一个组添加别名",
   "frequency: {frequency}": "运行次数: {frequency}",
   "No any group can be added": "没有可以添加的组",
-  "Are you sure to delete all aliases?": "确认删除所有的别名吗？",
+  "Please choose the aliases you want to delete": "请选择要删除的别名",
+  "Are you sure to delete all aliases?": "确定要删除所有别名吗？",
   "Confirm": "确认",
   "The .zshrc file on {path} doesn't exist. Do you want to create .zshrc file in this path?": "{path} 下.zshrc文件不存在，你想创建此文件吗？",
   "Create .zshrc file on {path} successfully": "{path} 下.zshrc文件创建成功",

package.nls.json

@@ -7,7 +7,7 @@
   "addAlias": "Add Alias",
   "copyAllAlias": "Copy All Alias",
   "deleteAlias": "Delete Alias",
-  "deleteAllAlias": "Delete All Alias",
+  "deleteAllAlias": "Delete Aliases",
   "run": "Run",
   "setDescription": "Set Description",
   "renameAliasName": "Rename Alias Name",

package.nls.zh-cn.json

@@ -7,7 +7,7 @@
   "addAlias": "新增别名",
   "copyAllAlias": "复制全部别名",
   "deleteAlias": "删除别名",
-  "deleteAllAlias": "删除所有别名",
+  "deleteAllAlias": "删除多个别名",
   "run": "运行",
   "setDescription": "更新备注",
   "renameAliasName": "重命名别名名称",

src/aliases.ts

@@ -1,6 +1,6 @@
 import { exec } from 'node:child_process'
 import fs from 'node:fs'
-import { isEmpty } from 'rattail'
+import { isEmpty, normalizeToArray } from 'rattail'
 import type { Alias } from './types'
 import { filterAliases, isSameAlias, resolveAlias } from './utils'
 
@@ -24,25 +24,26 @@ export function appendAliasToStoreFile(path: fs.PathOrFileDescriptor, content: s
   reloadStoreFile(path)
 }
 
-export function deleteAliases(path: fs.PathOrFileDescriptor, specificAlias?: Alias) {
+export function deleteAliases(path: fs.PathOrFileDescriptor, specificAlias: Alias | Alias[] = []) {
   const content = getContentFromPath(path)
 
   if (isEmpty(content)) {
     return
   }
 
+  const specificAliases = normalizeToArray(specificAlias)
   const data = content
     .split('\n')
     .map((text) => text.trim())
     .filter((text) => {
       const alias = resolveAlias(text)
 
-      if (!specificAlias) {
+      if (!specificAliases.length) {
         return !alias
       }
 
       if (alias) {
-        return !isSameAlias(alias, specificAlias)
+        return !specificAliases.some((specificAlias) => isSameAlias(alias, specificAlias))
       }
 
       return true

src/extension.ts

@@ -388,23 +388,43 @@ alias ${alias}`,
       return
     }
 
-    const text = await vscode.window.showInformationMessage(
-      vscode.l10n.t('Are you sure to delete all aliases?'),
-      { modal: true },
-      vscode.l10n.t('Confirm'),
+    const selectedAliases = await vscode.window.showQuickPick(
+      aliases.map((alias) => alias.aliasName),
+      {
+        placeHolder: vscode.l10n.t('Please choose the aliases you want to delete'),
+        canPickMany: true,
+      },
     )
-    // click cancel button
-    if (text === undefined) {
+
+    // cancel pick group
+    if (selectedAliases === undefined || !selectedAliases.length) {
       return
     }
 
-    executeCommandInTerminal(formatUnaliasCommand(aliases))
+    if (selectedAliases.length === aliases.length) {
+      const text = await vscode.window.showInformationMessage(
+        vscode.l10n.t('Are you sure to delete all aliases?'),
+        { modal: true },
+        vscode.l10n.t('Confirm'),
+      )
+      // click cancel button
+      if (text === undefined) {
+        return
+      }
+    }
+
+    const needDeleteAliases = aliases.filter((alias) => selectedAliases.includes(alias.aliasName))
 
-    deleteAliases(storePath.path)
+    executeCommandInTerminal(formatUnaliasCommand(needDeleteAliases))
 
-    // remove all aliases under every groups
+    deleteAliases(storePath.path, needDeleteAliases)
+
+    // remove aliases under every groups
     for (const groupName of this.globalState.keys()) {
-      this.globalState.update(groupName, [])
+      const aliases = normalizeAliasesToArray<Alias>(this.globalState.get(groupName)).filter((aliasItem) => {
+        return !needDeleteAliases.some((alias) => isSameAlias(alias, aliasItem))
+      })
+      this.globalState.update(groupName, aliases)
     }
 
     this.refresh()

tests/aliases.spec.ts

@@ -86,7 +86,15 @@ describe('test delete alias in .zshrc', () => {
     expect(fs.readFileSync(ZSHRC, 'utf-8')).toBe(`\nalias pnpm_version='pnpm -v'`)
   })
 
-  it('delete all alias in .zshrc', () => {
+  it('delete multiple aliases in .zshrc', () => {
+    deleteAliases(ZSHRC, [
+      { aliasName: 'pv', command: 'pnpm -v' },
+      { aliasName: 'pnpm_version', command: 'pnpm -v' },
+    ])
+    expect(fs.readFileSync(ZSHRC, 'utf-8')).toBe('')
+  })
+
+  it('delete all aliases in .zshrc', () => {
     deleteAliases(ZSHRC)
     expect(fs.readFileSync(ZSHRC, 'utf-8')).toBe('')
   })