Issue: Improve Unit Test Coverage for Generator Core Modules

[AnshumohanAcharya]

This issue aims to improve unit test coverage for the AsyncAPI Generator core modules, specifically focusing on generator.js, conditionalGeneration.js, and utils.js.

Current Status

• Overall Coverage: 60.61% statements
• Target Coverage: 80%+ statements

Current Coverage by File

• conditionalGeneration.js: 10.25% (very low)
• generator.js: 50.81% (core file, needs improvement)
• utils.js: ~67% (several untested utility functions)

Proposed Changes

1. conditionalGeneration.js (Priority: High)

• Create comprehensive test file: test/conditionalGeneration.test.js
• Test all functions: isGenerationConditionMet, conditionalParameterGeneration, conditionalSubjectGeneration, conditionalFilesGenerationDeprecatedVersion, validateStatus
• Cover edge cases and error paths
• Target: 100% coverage

2. generator.js (Priority: High)

• Add tests for getAllParameters (both new and old API paths)
• Add tests for ignoredDirHandler (conditional generation, .git skipping)
• Add tests for verifyTargetDir (git repo scenarios)
• Target: Improve from 50.81% to 65%+

3. utils.js (Priority: Medium)

• Add tests for untested utility functions: isFilePath, convertMapToObject, isAsyncFunction, registerTypeScript, convertCollectionToObject, getGeneratorVersion, isFileSystemPath
• Target: Improve from ~67% to 90%+

Expected Outcomes

• Improved test coverage from 60.61% to 73%+ statements
• Better code reliability through comprehensive test coverage
• Easier maintenance with tests documenting expected behavior
• Foundation for future coverage improvements

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Similar Issues

Possible Duplicates

• [Test]: Add Unit Tests for utils.js #1374

Related Issues

• [Test] Adding test to registered filters and hooks. #1412
• [Test] Adding test for cleanTestResultPaths helper function #1666
• [BUG] Tests failing due to requireg and workspace dependency resolution issues #1800
• [Test] Adding test for getDirElementsRecursive helper function #1668

👤 Suggested Assignees

• ssala034
• AnshumohanAcharya
• Adi-204

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord or schedule a call!

[dosubot]

Here’s a focused summary and actionable guidance for improving unit test coverage in the core modules:

For conditionalGeneration.js, target 100% coverage by testing all main functions: isGenerationConditionMet, conditionalParameterGeneration, conditionalSubjectGeneration, conditionalFilesGenerationDeprecatedVersion, and validateStatus. Make sure to cover both the legacy conditionalFiles and the current conditionalGeneration paths, including cases with missing configs, invalid parameters, and validation failures. The recent refactor means conditionalFilesGenerationDeprecatedVersion now delegates to conditionalSubjectGeneration, and validation logic is unified—so test both positive and negative outcomes for each function, especially where validation callbacks or missing subjects are involved. Note that conditionalFiles is deprecated and planned for removal around October, so prioritize tests that document current behavior but avoid investing heavily in deprecated paths [ref] [ref] [ref].

For generator.js, focus on getAllParameters (test both new and old API paths, including empty and populated documents), ignoredDirHandler (test directory creation, .git skipping, and conditional generation), and verifyTargetDir (test scenarios with/without git repos, with unstaged changes, and with/without the --force-write flag). Make sure to cover all error paths, especially those that throw when the directory is not empty or has uncommitted changes [ref] [ref].

For utils.js, add tests for all untested utility functions: isFilePath, convertMapToObject, isAsyncFunction, registerTypeScript, convertCollectionToObject, getGeneratorVersion, and isFileSystemPath. Cover edge cases such as empty inputs, invalid types, already-registered TypeScript environments, and both file path and URL detection. For file system utilities, maintainers recommend mocking dependencies like fs rather than using real directories [ref] [ref] [ref].

Maintainers encourage small, focused PRs for each function or logical group of tests, which helps with review and ongoing maintenance. Test-related issues are considered a great entry point for contributors and are actively prioritized [ref].

This approach will help you reach the targeted coverage and improve reliability and maintainability. If you need specific test case examples for any function, let me know!

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}