Skip to content

Add the pull secrets to values file instead of hardcoding it into deployment template #176

@msafwankarim

Description

@msafwankarim

Problem

I'm using helmify to generate chart from my Kustomize manfiests. I've defined pull secrets in kustomize manfiests but when I generate the chart it hardcodes those secrets into deployment.yaml. -image-pull-secret flag only works when imagePullSecrets are not defined in source manifests.

Desired behavior

If imagePullSecrets are defined they should be added into values.yaml file instead of hardcoding them into deployment spec. This will let the user override the imagePullSecrets while having some default value

Please let me know if this makes sense. I can work on this if it is something you want to include in the project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions