Remove memprof_enable() function (#107)

Enabling profiling during request may not work as expected because of PHP optimizations and observer behavior. Supporting that would increase overhead when not profiling. Using MEMPROF_PROFILE is now the only way to enable profiling.

Author: arnaud-lb

.github/workflows/test.yml

@@ -12,6 +12,7 @@ jobs:
   tests:
     name: 'Tests'
     strategy:
+      fail-fast: false
       matrix:
         include:
           - php: '8.4.0'

memprof.c

@@ -1765,28 +1765,6 @@ PHP_FUNCTION(memprof_memory_get_peak_usage)
 }
 /* }}} */
 
-/* {{{ proto bool memprof_enable()
-   Enables memprof */
-PHP_FUNCTION(memprof_enable)
-{
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "") == FAILURE) {
-		return;
-	}
-
-	if (MEMPROF_G(profile_flags).enabled) {
-		zend_throw_exception(EG(exception_class), "memprof_enable(): memprof is already enabled", 0);
-		return;
-	}
-
-	zend_error(E_WARNING, "Calling memprof_enable() manually may not work as expected because of PHP optimizations. Prefer using MEMPROF_PROFILE=1 as environment variable, GET, or POST");
-
-	MEMPROF_G(profile_flags).enabled = 1;
-	memprof_enable(&MEMPROF_G(profile_flags));
-
-	RETURN_TRUE;
-}
-/* }}} */
-
 /* {{{ proto bool memprof_disable()
    Disables memprof */
 PHP_FUNCTION(memprof_disable)

memprof.stub.php

@@ -9,8 +9,6 @@ function memprof_enabled(): bool {}
 
 function memprof_enabled_flags(): array {}
 
-function memprof_enable(): bool {}
-
 function memprof_disable(): bool {}
 
 function memprof_dump_array(): array {}

memprof_arginfo.h

@@ -1,14 +1,12 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: afb43b76aec85442c7267aba0b45bfd00d5c8cf1 */
+ * Stub hash: a8dec2138f524b2d8e0e5e07631e4965250fbbba */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_memprof_enabled, 0, 0, _IS_BOOL, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_memprof_enabled_flags, 0, 0, IS_ARRAY, 0)
 ZEND_END_ARG_INFO()
 
-#define arginfo_memprof_enable arginfo_memprof_enabled
-
 #define arginfo_memprof_disable arginfo_memprof_enabled
 
 #define arginfo_memprof_dump_array arginfo_memprof_enabled_flags
@@ -25,7 +23,6 @@ ZEND_END_ARG_INFO()
 
 ZEND_FUNCTION(memprof_enabled);
 ZEND_FUNCTION(memprof_enabled_flags);
-ZEND_FUNCTION(memprof_enable);
 ZEND_FUNCTION(memprof_disable);
 ZEND_FUNCTION(memprof_dump_array);
 ZEND_FUNCTION(memprof_dump_callgrind);
@@ -36,7 +33,6 @@ ZEND_FUNCTION(memprof_version);
 static const zend_function_entry ext_functions[] = {
 	ZEND_FE(memprof_enabled, arginfo_memprof_enabled)
 	ZEND_FE(memprof_enabled_flags, arginfo_memprof_enabled_flags)
-	ZEND_FE(memprof_enable, arginfo_memprof_enable)
 	ZEND_FE(memprof_disable, arginfo_memprof_disable)
 	ZEND_FE(memprof_dump_array, arginfo_memprof_dump_array)
 	ZEND_FE(memprof_dump_callgrind, arginfo_memprof_dump_callgrind)

package.xml

@@ -41,7 +41,6 @@
    <file name="INTERNALS.md" role="doc" />
    <file name="README.md" role="doc" />
    <dir name="tests">
-     <file name="001.phpt" role="test" />
      <file name="002.phpt" role="test" />
      <file name="003.phpt" role="test" />
      <file name="004.phpt" role="test" />