refactor: refactor notification delivery for modularity and testability

- Refactor configuration checks for iOS, Android, and Huawei platforms into separate validation functions
- Modularize APNS client initialization and payload construction with new helper functions for certificate/key loading and notification attribute setup
- Break notification payload generation into smaller, composable functions for improved clarity and testability
- Split FCM notification construction and payload formatting into dedicated helper functions
- Separate Huawei notification building into specific helper functions for message targets, Android config, and notification content
- Add extensive unit tests for new helper functions and refactored logic across iOS, Android/FCM, and Huawei notification handling
- Implement filtering and counting utilities for notification targets in the queue server logic
- Enhance code readability, maintainability, and test coverage throughout the notification module

Signed-off-by: appleboy <[email protected]>

Author: appleboy

notify/notification.go

@@ -197,45 +197,61 @@ func SetProxy(proxy string) error {
 	return nil
 }
 
-// CheckPushConf provide check your yml config.
-func CheckPushConf(cfg *config.ConfYaml) error {
-	if !cfg.Ios.Enabled && !cfg.Android.Enabled && !cfg.Huawei.Enabled {
-		return errors.New("please enable iOS, Android or Huawei config in yml config")
+// checkIOSConf validates iOS configuration.
+func checkIOSConf(cfg *config.ConfYaml) error {
+	if !cfg.Ios.Enabled {
+		return nil
 	}
-
-	if cfg.Ios.Enabled {
-		if cfg.Ios.KeyPath == "" && cfg.Ios.KeyBase64 == "" {
-			return errors.New("missing iOS certificate key")
-		}
-
-		// check certificate file exist
-		if cfg.Ios.KeyPath != "" {
-			if _, err := os.Stat(cfg.Ios.KeyPath); os.IsNotExist(err) {
-				return errors.New("certificate file does not exist")
-			}
+	if cfg.Ios.KeyPath == "" && cfg.Ios.KeyBase64 == "" {
+		return errors.New("missing iOS certificate key")
+	}
+	if cfg.Ios.KeyPath != "" {
+		if _, err := os.Stat(cfg.Ios.KeyPath); os.IsNotExist(err) {
+			return errors.New("certificate file does not exist")
 		}
 	}
+	return nil
+}
 
-	if cfg.Android.Enabled {
-		credential := os.Getenv("GOOGLE_APPLICATION_CREDENTIALS")
-		if cfg.Android.Credential == "" &&
-			cfg.Android.KeyPath == "" &&
-			credential == "" {
-			return errors.New("missing fcm credential data")
-		}
+// checkAndroidConf validates Android/FCM configuration.
+func checkAndroidConf(cfg *config.ConfYaml) error {
+	if !cfg.Android.Enabled {
+		return nil
 	}
+	credential := os.Getenv("GOOGLE_APPLICATION_CREDENTIALS")
+	if cfg.Android.Credential == "" && cfg.Android.KeyPath == "" && credential == "" {
+		return errors.New("missing fcm credential data")
+	}
+	return nil
+}
 
-	if cfg.Huawei.Enabled {
-		if cfg.Huawei.AppSecret == "" {
-			return errors.New("missing huawei app secret")
-		}
+// checkHuaweiConf validates Huawei/HMS configuration.
+func checkHuaweiConf(cfg *config.ConfYaml) error {
+	if !cfg.Huawei.Enabled {
+		return nil
+	}
+	if cfg.Huawei.AppSecret == "" {
+		return errors.New("missing huawei app secret")
+	}
+	if cfg.Huawei.AppID == "" {
+		return errors.New("missing huawei app id")
+	}
+	return nil
+}
 
-		if cfg.Huawei.AppID == "" {
-			return errors.New("missing huawei app id")
-		}
+// CheckPushConf provide check your yml config.
+func CheckPushConf(cfg *config.ConfYaml) error {
+	if !cfg.Ios.Enabled && !cfg.Android.Enabled && !cfg.Huawei.Enabled {
+		return errors.New("please enable iOS, Android or Huawei config in yml config")
 	}
 
-	return nil
+	if err := checkIOSConf(cfg); err != nil {
+		return err
+	}
+	if err := checkAndroidConf(cfg); err != nil {
+		return err
+	}
+	return checkHuaweiConf(cfg)
 }
 
 // SendNotification provide send notification.