Users MonitorId field orphaned in older installs #4505
Description
Describe Your Environment
Version of ZoneMinder 1.37.73
Describe the bug
I was working on my API and had an issue where my API that had the ORM entities built from existing DB has the MonitorId field in the users table, but my test db that was created from zm_create did not.
Found the root cause In this commit 75f0ee8 the MonitorId field was removed from zm_create.sql. But no db update script was done with that commit. The db update commit is defba5d but that only adds the new fields and didn't clean up the field from anyone upgrading.
To Reproduce
Steps to reproduce the behavior:
- Install version pre 1st March 2023
- Upgrade to current versions
- Users table will still have monitorId field.
Expected behavior
We should clean this up for existing installs, and preferably before 1.38. Looks like the values in the table were migrated to Monitors_permissions at some point so seems safe to ditch that field.