Skip to content

Commit 56694f4

Browse files
committed
Merge branch 'release/v3.0.0'
2 parents 0873e74 + a76b3c1 commit 56694f4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+4791
-17274
lines changed

.editorconfig

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# EditorConfig is awesome: https://EditorConfig.org
2+
3+
# top-most EditorConfig file
4+
root = true
5+
6+
# All files
7+
[*]
8+
charset = utf-8
9+
end_of_line = lf
10+
insert_final_newline = true
11+
trim_trailing_whitespace = true
12+
13+
# TypeScript, JavaScript, CSS, HTML, JSON, Markdown
14+
[*.{ts,js,css,html,md}]
15+
indent_style = space
16+
indent_size = 4
17+
max_line_length = 150
18+
19+
# Markdown files
20+
[*.md]
21+
trim_trailing_whitespace = false
22+
max_line_length = off
23+
24+
# CSS files specific
25+
[*.{css,postcss}]
26+
indent_style = space
27+
indent_size = 2
28+
block_comment_start = /*
29+
block_comment = *
30+
block_comment_end = */
31+
32+
# Package files
33+
[*.json]
34+
indent_style = space
35+
indent_size = 2
36+
37+
# Config files
38+
[*.{yml,yaml,conf}]
39+
indent_style = space
40+
indent_size = 2

.eslintrc

Lines changed: 0 additions & 23 deletions
This file was deleted.

.github/workflows/deploy-pages.yml

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# Simple workflow for deploying static content to GitHub Pages
2+
name: Deploy static content to Pages
3+
4+
on:
5+
# Runs on pushes targeting the default branch
6+
push:
7+
branches: ["master"]
8+
9+
# Allows you to run this workflow manually from the Actions tab
10+
workflow_dispatch:
11+
12+
# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
13+
permissions:
14+
contents: read
15+
pages: write
16+
id-token: write
17+
18+
# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
19+
# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
20+
concurrency:
21+
group: "pages"
22+
cancel-in-progress: false
23+
24+
jobs:
25+
# Single deploy job since we're just deploying
26+
deploy:
27+
environment:
28+
name: github-pages
29+
url: ${{ steps.deployment.outputs.page_url }}
30+
runs-on: ubuntu-latest
31+
steps:
32+
- name: Checkout
33+
uses: actions/checkout@v4
34+
- name: Setup Pages
35+
uses: actions/configure-pages@v5
36+
- name: Upload artifact
37+
uses: actions/upload-pages-artifact@v3
38+
with:
39+
# Upload docs/dist directory
40+
path: 'docs/dist'
41+
- name: Deploy to GitHub Pages
42+
id: deployment
43+
uses: actions/deploy-pages@v4

.gitignore

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
node_modules
2-
bower_components
3-
yarn-error.log
4-
5-
# IntelliJ project files
6-
.idea
7-
2+
dist_tests
3+
yarn.lock
4+
package-lock.json
5+
pnpm-lock.yaml

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v22.11.0

.vscode/extensions.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
2+
{
3+
"recommendations": [
4+
"dbaeumer.vscode-eslint",
5+
"esbenp.prettier-vscode",
6+
"EditorConfig.EditorConfig"
7+
]
8+
}

.vscode/settings.json

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
{
2+
"editor.formatOnSave": true,
3+
"editor.codeActionsOnSave": {
4+
"source.fixAll.eslint": "never"
5+
},
6+
"editor.defaultFormatter": null,
7+
"[javascript]": {
8+
"editor.defaultFormatter": "esbenp.prettier-vscode"
9+
},
10+
"[typescript]": {
11+
"editor.defaultFormatter": "esbenp.prettier-vscode"
12+
},
13+
"[json]": {
14+
"editor.defaultFormatter": "esbenp.prettier-vscode"
15+
},
16+
"[css]": {
17+
"editor.defaultFormatter": "esbenp.prettier-vscode"
18+
},
19+
"[html]": {
20+
"editor.defaultFormatter": "esbenp.prettier-vscode"
21+
},
22+
"editor.tabSize": 2,
23+
"editor.insertSpaces": true,
24+
"files.eol": "\n",
25+
"files.trimTrailingWhitespace": true,
26+
"files.insertFinalNewline": true,
27+
"editor.rulers": [150],
28+
"editor.wordWrapColumn": 150
29+
}

CONTRIBUTING.md

Lines changed: 124 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,124 @@
1-
### Contributing
2-
- Give it a [star](https://github.com/VincentLoy/simplyCountdown.js/stargazers) !
3-
- [Report a bug](https://github.com/VincentLoy/simplyCountdown.js/issues)
4-
- Tweet about it :)
5-
6-
#### Pull Requests
7-
- **Solve a problem**
8-
- For code enhancement, use [ESLint](https://eslint.org/) as a code quality tool.
9-
- Small is better than Big.
1+
# Contributing to SimplyCountdown.js
2+
3+
🎉 Thank you for considering contributing to SimplyCountdown.js! I appreciate your support and I'm excited to collaborate with you. Below are the guidelines to help you get started.
4+
5+
## How to Contribute
6+
7+
### ⭐ 0. Give a Star to the Repository
8+
9+
This step is totally optional... but seriously, who doesn't love some stars? 😉
10+
It's like giving a virtual high-five to the project! 🙌 ⭐ 🙌
11+
12+
### 🔱 1. Fork the Repository
13+
14+
Start by forking the repository to your GitHub account.
15+
16+
### 📥 2. Clone Your Fork
17+
18+
Clone your forked repository to your local machine:
19+
20+
```bash
21+
git clone [email protected]:your-username/simplyCountdown.js.git
22+
cd simplyCountdown.js
23+
```
24+
25+
### 🔧 3. Node.js Version
26+
27+
Make sure you're using the correct Node.js version. You can check the required version in `.nvmrc`. If you use [nvm](https://github.com/nvm-sh/nvm), simply run:
28+
29+
```bash
30+
nvm use
31+
```
32+
33+
This will automatically switch to the correct Node.js version for the project.
34+
35+
### 🛠️ 4. Set Up the Development Environment
36+
37+
Install the necessary dependencies:
38+
We recommend using [bun](https://bun.sh/) as it offers superior performance and seamless dependency management.
39+
40+
```bash
41+
bun install
42+
```
43+
44+
**NOTE:** _For now, `package.json` is running bun commands only, maybe we will have to update this to be compatible with any package management system in the future_
45+
46+
### 🌿 5. Create a Branch
47+
48+
Create a new branch for your feature or bugfix:
49+
50+
```bash
51+
git checkout -b feature/your-feature-name
52+
```
53+
54+
### 💻 6. Make Your Changes
55+
56+
Make your changes to the codebase. Ensure your code follows the project's code style and formatting guidelines.
57+
While developping, you should run this command:
58+
59+
```bash
60+
bun run dev
61+
```
62+
63+
**NOTE:** _This will run a dev server with Vite, update the sources from `src/core` and tests your new features in `docs/src` files like `docs/src/index.html` and `docs/src/assets/js/main.js`. Each changes inside those files will refresh the dev page_
64+
65+
### ✅ 7. Test Your Changes
66+
67+
Build, then, run the tests to make sure your changes don't break anything:
68+
69+
```bash
70+
bun run build
71+
```
72+
73+
then:
74+
75+
```bash
76+
bun run dist:test:serve
77+
```
78+
79+
**NOTE:** _This will generate various HTML files inside a `dist_test` directory and run a temporary node.js server where you can check different implementations and use-cases of the distribution files. Every HTML pages should run a working countdown._
80+
81+
### 💾 8. Commit Your Changes
82+
83+
Commit your changes with a clear and concise commit message:
84+
85+
```bash
86+
git add .
87+
git commit -m "Add feature: your feature description"
88+
```
89+
90+
### 🚀 9. Push to Your Fork
91+
92+
Push your changes to your forked repository:
93+
94+
```bash
95+
git push origin feature/your-feature-name
96+
```
97+
98+
### 🔄 10. Open a Pull Request
99+
100+
Open a pull request from your forked repository to the main repository. Provide a detailed description of your changes and any relevant information.
101+
102+
## Pull Request Process
103+
104+
- Provide a detailed description of your changes in the pull request.
105+
- Link any relevant issues in the pull request description.
106+
- Wait for a maintainer to review your pull request.
107+
108+
## Creating Issues
109+
110+
If you find a bug or have a feature request, please create an issue in the repository. Provide as much detail as possible, including steps to reproduce the issue or a clear description of the feature.
111+
112+
## Code Review Process
113+
114+
All pull requests will be reviewed by a maintainer. The review process includes:
115+
116+
- Checking for code quality and adherence to the style guide.
117+
- Ensuring tests are passing.
118+
- Providing feedback and requesting changes if necessary.
119+
120+
## Documentation
121+
122+
For more information about the project, please refer to the [README.md](README.md) and the [documentation website](https://vincentloy.github.io/simplyCountdown.js/).
123+
124+
Thank you for contributing! 🚀

LICENSE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2015 Vincent Loy
3+
Copyright (c) 2015-present Vincent Loy
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal
@@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
1818
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
1919
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
2020
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
21-
THE SOFTWARE.
21+
THE SOFTWARE.

0 commit comments

Comments
 (0)