Skip to content

Commit c223bc9

Browse files
authored
Do not check for dependencies (#16)
* Do not check for dependencies * Use XML doc
1 parent 9359180 commit c223bc9

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

SeeShark/FFmpeg/FFmpegManager.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,11 @@ public static bool CanLoadLibraries(LibraryFlags libraries = LibraryFlags.All, s
118118
return libraries.ToStrings().All((lib) => canLoadLibrary(lib, path, validated));
119119
}
120120

121-
// Note: recurses in a very similar way to the LoadLibrary() method.
121+
/// <remarks>
122+
/// Note: dependencies are not checked as they are optional in FFmpeg.AutoGen.
123+
/// See <see href="https://github.com/Ruslan-B/FFmpeg.AutoGen/commit/395dea80c642c85e089e3d7721f91d77594655c1">the following commit</see>
124+
/// and <see href="https://github.com/Ruslan-B/FFmpeg.AutoGen/blob/633c15d323785092561329ad4b5742b0189116d6/FFmpeg.AutoGen/FFmpeg.cs#L57-L82">this function</see>
125+
/// </remarks>
122126
private static bool canLoadLibrary(string lib, string path, List<string> validated)
123127
{
124128
if (validated.Contains(lib))
@@ -129,9 +133,7 @@ private static bool canLoadLibrary(string lib, string path, List<string> validat
129133
return false;
130134

131135
validated.Add(lib);
132-
133-
var dependencies = ffmpeg.LibraryDependenciesMap[lib];
134-
return dependencies.Except(validated).All((dep) => canLoadLibrary(dep, path, validated));
136+
return true;
135137
}
136138

137139
/// <summary>

0 commit comments

Comments
 (0)