Refactor transaction commands to use factory method for TransactionData instantiation and remove redundant override in balance method

twisti-dev · twisti-dev · commit 7abfee11b1cc · 2025-12-26T18:06:06.000+01:00
diff --git a/surf-transaction-core/src/main/kotlin/dev/slne/surf/transaction/core/transaction/TransactionServiceImpl.kt b/surf-transaction-core/src/main/kotlin/dev/slne/surf/transaction/core/transaction/TransactionServiceImpl.kt
@@ -97,7 +97,7 @@ class TransactionServiceImpl: TransactionService {
         return TransactionRepository.transfer(senderTransaction, receiverTransaction)
     }
 
-    override suspend fun balance(
+    suspend fun balance(
         account: Account,
         currency: Currency
     ): BigDecimal {
diff --git a/surf-transaction-paper/src/main/kotlin/dev/slne/surf/transaction/paper/commands/transaction/admin/subcommands/TransactionAddCommand.kt b/surf-transaction-paper/src/main/kotlin/dev/slne/surf/transaction/paper/commands/transaction/admin/subcommands/TransactionAddCommand.kt
@@ -54,7 +54,7 @@ private suspend fun add(
         amount = amount.toBigDecimal(),
         currency = currency,
         additionalData = arrayOf(
-            TransactionData(
+            TransactionData.of(
                 "admin.transaction.add",
                 (sender as? Player)?.uniqueId?.toString() ?: sender.name
             )
diff --git a/surf-transaction-paper/src/main/kotlin/dev/slne/surf/transaction/paper/commands/transaction/admin/subcommands/TransactionRemoveCommand.kt b/surf-transaction-paper/src/main/kotlin/dev/slne/surf/transaction/paper/commands/transaction/admin/subcommands/TransactionRemoveCommand.kt
@@ -55,7 +55,7 @@ private suspend fun remove(
         currency = currency,
         ignoreMinimum = true,
         additionalData = arrayOf(
-            TransactionData(
+            TransactionData.of(
                 "admin.transaction.remove",
                 (sender as? Player)?.uniqueId?.toString() ?: sender.name
             )

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ class TransactionServiceImpl: TransactionService {`
`97`	`97`	`return TransactionRepository.transfer(senderTransaction, receiverTransaction)`
`98`	`98`	`}`
`99`	`99`
`100`		`- override suspend fun balance(`
	`100`	`+ suspend fun balance(`
`101`	`101`	`account: Account,`
`102`	`102`	`currency: Currency`
`103`	`103`	`): BigDecimal {`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ private suspend fun add(`
`54`	`54`	`amount = amount.toBigDecimal(),`
`55`	`55`	`currency = currency,`
`56`	`56`	`additionalData = arrayOf(`
`57`		`- TransactionData(`
	`57`	`+ TransactionData.of(`
`58`	`58`	`"admin.transaction.add",`
`59`	`59`	`(sender as? Player)?.uniqueId?.toString() ?: sender.name`
`60`	`60`	`)`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ private suspend fun remove(`
`55`	`55`	`currency = currency,`
`56`	`56`	`ignoreMinimum = true,`
`57`	`57`	`additionalData = arrayOf(`
`58`		`- TransactionData(`
	`58`	`+ TransactionData.of(`
`59`	`59`	`"admin.transaction.remove",`
`60`	`60`	`(sender as? Player)?.uniqueId?.toString() ?: sender.name`
`61`	`61`	`)`