Merge pull request #19 from SLNE-Development/fix/rename-player-creator-type

fix: rename NpcCreatorType.Player to NpcCreatorType.Client

Author: ammodev

gradle.properties

@@ -1,4 +1,4 @@
 kotlin.code.style=official
 kotlin.stdlib.default.dependency=false
 org.gradle.parallel=true
-version=1.21.7-1.4.1-SNAPSHOT
+version=1.21.7-1.4.2-SNAPSHOT

surf-npc-api/src/main/kotlin/dev/slne/surf/npc/api/npc/NpcCreatorType.kt

@@ -10,7 +10,7 @@ sealed class NpcCreatorType() {
      *
      * @property name The name of the player who created the NPC.
      */
-    data class Player(val name: String) : NpcCreatorType()
+    data class Client(val name: String) : NpcCreatorType()
 
     /**
      * Represents a plugin as the creator of the NPC.
@@ -24,8 +24,8 @@ sealed class NpcCreatorType() {
      *
      * @return `true` if the creator is a player, otherwise `false`.
      */
-    fun isPlayer(): Boolean {
-        return this is Player
+    fun isClient(): Boolean {
+        return this is Client
     }
 
     /**
@@ -45,7 +45,7 @@ sealed class NpcCreatorType() {
 
     fun name(): String {
         return when (this) {
-            is Player -> name
+            is Client -> name
             is Plugin -> name
         }
     }

surf-npc-bukkit/src/main/kotlin/dev/slne/surf/npc/bukkit/command/sub/NpcCreateCommand.kt

@@ -60,7 +60,7 @@ class NpcCreateCommand(commandName: String) : CommandAPICommand(commandName) {
                     BukkitNpcRotation(location.yaw, location.pitch),
                     true,
                     persistent = true,
-                    npcCreatorType = NpcCreatorType.Player(createdBy)
+                    npcCreatorType = NpcCreatorType.Client(createdBy)
                 )
 
                 if (npcResult.isFailure()) {

surf-npc-bukkit/src/main/kotlin/dev/slne/surf/npc/bukkit/npc/property/impl/NpcCreatorTypePropertyType.kt

@@ -6,15 +6,15 @@ import dev.slne.surf.npc.api.npc.property.NpcPropertyType
 class NpcCreatorTypePropertyType(override val id: String) : NpcPropertyType {
     override fun encode(value: Any): String {
         require(value is NpcCreatorType) { "Expected NpcCreatorType, got ${value::class}" }
-        return "${if (value.isPlayer()) "player" else "plugin"}:${value.name()}"
+        return "${if (value.isClient()) "player" else "plugin"}:${value.name()}"
     }
 
     override fun decode(value: String): NpcCreatorType {
         val parts = value.split(":")
         require(parts.size == 2) { "Invalid creator type format: $value" }
 
         return when (parts[0]) {
-            "player" -> NpcCreatorType.Player(parts[1])
+            "player" -> NpcCreatorType.Client(parts[1])
             "plugin" -> NpcCreatorType.Plugin(parts[1])
             else -> throw IllegalArgumentException("Unknown creator type: ${parts[0]}")
         }