Skip to content

Commit 9c7609b

Browse files
authored
Address JDoc errors and warnings (#55)
1 parent 40ad6ea commit 9c7609b

File tree

4 files changed

+12
-28
lines changed

4 files changed

+12
-28
lines changed

src/main/java/io/rebloom/client/Client.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public boolean add(String name, byte[] value) {
150150
* @param name The name of the filter
151151
* @param options {@link io.rebloom.client.InsertOptions}
152152
* @param items items to add to the filter
153-
* @return
153+
* @return an array of booleans
154154
*/
155155
public boolean[] insert(String name, InsertOptions options, String... items) {
156156
final List<byte[]> args = new ArrayList<>();
@@ -278,7 +278,7 @@ public boolean[] existsMulti(String name, String ...values) {
278278

279279
/**
280280
* Remove the filter
281-
* @param name
281+
* @param name filter name
282282
* @return true if delete the filter, false is not delete the filter
283283
*/
284284
public boolean delete(String name) {
@@ -289,8 +289,8 @@ public boolean delete(String name) {
289289

290290
/**
291291
* Get information about the filter
292-
* @param name
293-
* @return Return information
292+
* @param name filter name
293+
* @return information
294294
*/
295295
public Map<String, Object> info(String name) {
296296
try (Jedis conn = _conn()) {
@@ -302,11 +302,6 @@ public Map<String, Object> info(String name) {
302302
* TOPK.RESERVE key topk width depth decay
303303
*
304304
* Reserve a topk filter.
305-
* @param key The key of the filter
306-
* @param topk
307-
* @param width
308-
* @param depth
309-
* @param decay
310305
*
311306
* Note that if a filter is not reserved, a new one is created when {@link #add(String, byte[])}
312307
* is called.
@@ -341,7 +336,7 @@ public List<String> topkAdd(String key, String ...items) {
341336
* Adds an item to the filter
342337
* @param key The key of the filter
343338
* @param item The item to increment
344-
* @param increment
339+
* @param increment The increment
345340
* @return item dropped from the list.
346341
*/
347342
public String topkIncrBy(String key, String item, long increment) {

src/main/java/io/rebloom/client/ClusterClient.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public Boolean execute(Jedis connection) {
155155
* @param name The name of the filter
156156
* @param options {@link io.rebloom.client.InsertOptions}
157157
* @param items items to add to the filter
158-
* @return
158+
* @return array of booleans
159159
*/
160160
public boolean[] insert(String name, InsertOptions options, String... items) {
161161
return (new JedisClusterCommand<boolean[]>(this.connectionHandler, this.maxAttempts) {
@@ -259,7 +259,7 @@ public boolean[] execute(Jedis connection) {
259259

260260
/**
261261
* Remove the filter
262-
* @param name
262+
* @param name Name of filter to delete
263263
* @return true if delete the filter, false is not delete the filter
264264
*/
265265
public boolean delete(String name) {
@@ -275,7 +275,7 @@ public Boolean execute(Jedis connection) {
275275

276276
/**
277277
* Get information about the filter
278-
* @param name
278+
* @param name Name of filter to get info
279279
* @return Return information
280280
*/
281281
public Map<String, Object> info(String name) {
@@ -304,10 +304,6 @@ public Map<String, Object> execute(Jedis connection) {
304304
*
305305
* Reserve a topk filter.
306306
* @param key The key of the filter
307-
* @param topk
308-
* @param width
309-
* @param depth
310-
* @param decay
311307
*
312308
* Note that if a filter is not reserved, a new one is created when {@link #add(String, byte[])}
313309
* is called.
@@ -353,6 +349,7 @@ public List<String> execute(Jedis jedis) {
353349
* Adds an item to the filter
354350
* @param key The key of the filter
355351
* @param item The item to increment
352+
* @param increment The increment
356353
* @return item dropped from the list.
357354
*/
358355
public String topkIncrBy(String key, String item, long increment) {

src/main/java/io/rebloom/client/InsertOptions.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ public static InsertOptions insertOptions() {
1616
}
1717
/**
1818
* If specified, should be followed by the desired capacity for the filter to be created
19-
* @param capacity
20-
* @return
2119
*/
2220
public InsertOptions capacity(final long capacity) {
2321
options.add(CAPACITY.getRaw());
@@ -27,8 +25,6 @@ public InsertOptions capacity(final long capacity) {
2725

2826
/**
2927
* If specified, should be followed by the the error ratio of the newly created filter if it does not yet exist
30-
* @param errorRate
31-
* @return
3228
*/
3329
public InsertOptions error(final double errorRate) {
3430
options.add(ERROR.getRaw());
@@ -39,7 +35,6 @@ public InsertOptions error(final double errorRate) {
3935
/**
4036
* If specified, indicates that the filter should not be created if it does not already exist
4137
* It is an error to specify NOCREATE together with either CAPACITY or ERROR .
42-
* @return
4338
*/
4439
public InsertOptions nocreate() {
4540
options.add(NOCREATE.getRaw());

src/main/java/io/rebloom/client/cf/Cuckoo.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,7 @@ public interface Cuckoo {
153153
* proper sequence.
154154
*
155155
* @param key Name of the filter
156-
* @return Returns an iterator over the Map.Entry<Long, byte[]> containing the chunks
157-
* of byte[] representing the filter
156+
* @return An iterator over the Pair containing the chunks of byte[] representing the filter
158157
*/
159158
Iterator<Map.Entry<Long, byte[]>> cfScanDumpIterator(String key);
160159

@@ -166,8 +165,7 @@ public interface Cuckoo {
166165
* Returns a sequential Stream with the Map.Entry containing the Iterator and
167166
* Data as its source.
168167
*
169-
* @return Returns a sequential Stream of Map.Entry<Long, byte[]> containing the Iterator and
170-
* Data
168+
* @return A sequential Stream of Pair of iterator and data
171169
*/
172170
Stream<Map.Entry<Long, byte[]>> cfScanDumpStream(String key);
173171

@@ -176,8 +174,7 @@ public interface Cuckoo {
176174
* SCANDUMP command for example usage.
177175
*
178176
* @param key Name of the filter to restore
179-
* @param iterAndData a Map.Entry<Long, byte[]> containing the Iterator and
180-
* Data.
177+
* @param iterAndData Pair of iterator and data
181178
*/
182179
void cfLoadChunk(String key, Map.Entry<Long, byte[]> iterAndData);
183180

0 commit comments

Comments
 (0)