unreachable code lint warnings

[jcurtiss8086]

To help with identifying and cleaning up dead-code, here are a few items I would love to see lint warnings for.

packages:

• Unused variables
• Unused typedefs
• Unused functions/tasks

classes:

• Unused member variables
• Unused functions/tasks

There is an 'unreachable code' item listed in the current issue that tracks the implementation of lint warnings. Would that item cover all of the above?

[MikePopoloski]

No, "unreachable" means identifying code like the following:

function void foo;
  if (1) // always true
    return;
  doSomething(); // unreachable
endfunction

There are already warnings for unused variables and typedefs. Adding another for functions and tasks would not be hard.

[jcurtiss8086]

I have the following options enabled:

-Werror=unused-typedef
-Werror=unused-variable

But they don't appear to flag unused variables/typedefs within packages, or for unused class member-variables. Unused typedefs defined within classes does get flagged though.

[MikePopoloski]

Ah that's right, the existing warnings specifically exclude package members. Probably they deserve their own warning group. Same for class member variables.

[jcurtiss8086]

Should I submit a new feature-request, or do you just want to add those to the existing issue that tracks new lint rules?

[MikePopoloski]

Either is fine with me. Maybe a new issue is best just to make sure the details are captured from this discussion.