Minor test fixes

Author: Kovah

tests/Controller/App/ImportControllerTest.php

@@ -66,8 +66,8 @@ public function testDatelessImportActionResponse(): void
 
     public function testImportWithPrivateDefaults(): void
     {
-        Setting::create(['user_id' => 1, 'key' => 'links_private_default', 'value' => '1']);
-        Setting::create(['user_id' => 1, 'key' => 'tags_private_default', 'value' => '1']);
+        Setting::updateOrCreate(['user_id' => 1, 'key' => 'links_private_default'], ['value' => '1']);
+        Setting::updateOrCreate(['user_id' => 1, 'key' => 'tags_private_default'], ['value' => '1']);
 
         $response = $this->importBookmarks();
 

tests/Controller/App/SystemSettingsControllerTest.php

@@ -4,6 +4,8 @@
 
 use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\Cache;
+use Illuminate\Support\Facades\Config;
 use Tests\TestCase;
 
 class SystemSettingsControllerTest extends TestCase
@@ -32,16 +34,13 @@ public function testValidSettingsResponse(): void
 
     public function testValidSettingsUpdateResponse(): void
     {
-        $response = $this->get('dashboard');
-        $response->assertDontSee('Begin of custom header scripts');
+        $this->get('dashboard')->assertDontSee('Begin of custom header scripts');
 
-        $response = $this->post('settings/system', [
+        $this->post('settings/system', [
             'system_page_title' => 'New Title',
             'system_guest_access' => '1',
             'system_custom_header_content' => '<script>console.log(\'scripts work\')</script>',
-        ]);
-
-        $response->assertRedirect('settings/system');
+        ])->assertRedirect('settings/system')->assertSessionHasNoErrors();
 
         $this->assertDatabaseHas('settings', [
             'user_id' => null,