Skip to content

Support const graph methods #22

@Hoshiningen

Description

@Hoshiningen

The similarity and voronoi graphs both use an inherited implementation class to hide the implementation details from the compiler. The way this was implemented, it can't support having constant methods in the public API of the class that inherits from the implementation class.

This is not ideal, as external methods can't accept const types with that implementation class. They have to take them by value or by reference.

void Render(SimilarityGraph& simGraph)
{
   // This would be better if simGraph was constant because otherwise, it's able to modify the graph, and passing by value is expensive
}

Acceptance Criteria:

  • The implementation class that the Similarity and Voronoi Graphs use has been modified to allow constant operations

Metadata

Metadata

Assignees

No one assigned

    Labels

    apiImprovements to the API

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions