[HOTFIX] Fixing bug where Variable.hasSetter returned true for explicit getter only

Author: mobrien-ghost

Sources/SyntaxSparrow/Internal/Resolvers/Declaration/VariableSemanticsResolver.swift

@@ -116,6 +116,9 @@ struct VariableSemanticsResolver: SemanticsResolving {
         // Resolver accessors for assessment
         let accessors = resolveAccessors()
         let accessorKinds = accessors.compactMap(\.kind)
+        // Only getter accessors mean that there is no setters
+        guard accessorKinds != [.get] else { return false }
+        // General setter check
         let hasSetterAccessor = accessorKinds.contains(where: { [.set, .willSet, .didSet].contains($0) })
         let hasEffectGetter = accessors.contains(where: {
             let hasSpecifier = ($0.effectSpecifiers?.throwsSpecifier != nil || $0.effectSpecifiers?.asyncSpecifier != nil)
@@ -125,7 +128,7 @@ struct VariableSemanticsResolver: SemanticsResolving {
         guard !hasEffectGetter else { return false }
         // If setter exists in accessors can return true (usually protocol context or manually written will/did/set accessor).
         if hasSetterAccessor { return true }
-        // If no accessors, but a direct return/code block, can assume there is no setter
+        // If no accessors, but a direct return/code block, can assume there is no setter. (computed var)
         if accessors.isEmpty, resolveHasCodeBlockItems() { return false }
         // Otherwise if the keyword is not `let` (immutable)
         guard resolveKeyword() != "let" else { return false }

Tests/SyntaxSparrowTests/Declarations/VariableTests.swift

@@ -66,6 +66,24 @@ final class VariableTests: XCTestCase {
         XCTAssertFalse(variable.hasSetter)
     }
 
+    func test_variable_mutable_onlyGetter_willReturnFalseForHasSetter() {
+        let source = #"""
+        var name: String {
+            get { "test" }
+        }
+        var other: String {
+            "test"
+        }
+        """#
+        instanceUnderTest.updateToSource(source)
+        XCTAssertTrue(instanceUnderTest.isStale)
+        instanceUnderTest.collectChildren()
+        XCTAssertFalse(instanceUnderTest.isStale)
+        XCTAssertEqual(instanceUnderTest.variables.count, 2)
+        XCTAssertFalse(instanceUnderTest.variables[0].hasSetter)
+        XCTAssertFalse(instanceUnderTest.variables[1].hasSetter)
+    }
+
     func test_variable_multiplePatternBindings_willResolveExpectedValues() {
         let source = #"""
         var firstName, lastName: String
@@ -297,7 +315,7 @@ final class VariableTests: XCTestCase {
         XCTAssertFalse(instanceUnderTest.variables[4].isComputed)
         XCTAssertTrue(instanceUnderTest.variables[5].isComputed)
         XCTAssertTrue(instanceUnderTest.variables[6].isComputed)
-        XCTAssertFalse(instanceUnderTest.variables[7].isComputed)
+        XCTAssertTrue(instanceUnderTest.variables[7].isComputed)
     }
 
     func test_variable_hasSetterHelper_willResolveExpectedValues() {