build: add target_link_directories because we're pulling a library from a file and not a target

Author: kaixoo12

app/CMakeLists.txt

@@ -3,6 +3,12 @@ add_executable(${CMAKE_PROJECT_NAME} main.cpp)
 
 message("   finding where Skia shared library is")
 include(FindSkiaSystem)
+message("   set SKIA_LIBRARIES to ${SKIA_LIBRARIES}")
+
+message("-- Use target_link_directories to")
+message("   tell target where to look for .dlls")
+message("   (by default in CMake +3 it is recommended to link by targets, not directories)")
+target_link_directories(${CMAKE_PROJECT_NAME} PRIVATE ${CMAKE_BINARY_DIR}/src)
 
 set(EXECUTABLE_LIBRARIES
         ${APP_DEPENDENCIES}
@@ -13,5 +19,5 @@ set(EXECUTABLE_LIBRARIES
 message("   linked with ${EXECUTABLE_LIBRARIES}")
 
 # Finally join our libraries with the executable
-target_link_libraries(${CMAKE_PROJECT_NAME} ${EXECUTABLE_LIBRARIES})
+target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE ${EXECUTABLE_LIBRARIES})
 

buildscripts/skia/CopySkiaLibraryToInstallDir.cmake

@@ -1,8 +1,10 @@
 message("-- Generated shared library")
 message("   from target Engine")
 message("   in ${SKIA_BUILD_DIR}/libskia.friction.so")
-message("-- Moving libskia.friction.so")
-message("   to ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}")
 
+message("-- Moving libskia.friction.so")
+message("   to ${CMAKE_BINARY_DIR}/src")
+message("   so it is importable using \"\"")
 file(COPY ${SKIA_BUILD_DIR}/libskia.friction.so
-     DESTINATION ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR})
+     DESTINATION ${CMAKE_BINARY_DIR}/src)
+

thirdparty/skia/CMakeLists.txt

@@ -70,7 +70,7 @@ ExternalProject_Add(
 
 
 if(UNIX AND NOT APPLE)
-    #include(CopySkiaLibraryToInstallDir)
+    include(CopySkiaLibraryToInstallDir)
 endif()